department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Design | Appointment Reminders PHI/PII | designs showing the opt in permission for PII/PHI for appointment reminders #86208

Open mtcA6 opened 2 months ago

mtcA6 commented 2 months ago

Background

We need to incorporate an additional set of checkboxes into the notification settings for users to opt in or out of receiving PHI/PII in their appointment reminders.

Work was begun before a11y and technical constraints were known. Artifacts in Figma are there for discussion and illustration.

See comments for these constraints.

There are not existing VADS patterns for this kind of interaction, so work will need to be done to create a bespoke pattern.

Working Figma file on page titled "Desktop - PHI/PII Notifications After Design Intent"

Comment from previous designer

I know I won't be working on this, but fwiw, I think it will be most clear to people if the PII/PHI option is a secondary step or something layered on top of the overall permission. E.g. first they indicate they want to be notified and then we ask if they want to have PII included. Originally posted by @andaleliz in https://github.com/department-of-veterans-affairs/va.gov-team/issues/58797#issuecomment-2161424266

Tasks

Acceptance Criteria

~OR~

ACParker89 commented 1 month ago

@twoangstroms - do you have an update on this ticket? Is it in progress?

CC: @mtcA6

twoangstroms commented 1 month ago

Not in progress yet but will this week. Revamping ILER based on actual info from stakeholders has been a lot.

ACParker89 commented 1 month ago

This story is a sprint priority, so that development can begin in the next sprint. If you'd like we can set up a call and chat through the tasks tomorrow. Can we have this completed by Wednesday before planning so that they can jump into it?

twoangstroms commented 1 month ago

@ACParker89 @mtcA6 Does this ticket include deleting the text "Manage your health care email notifications on My HealtheVet" in this design? Because it seems that adding the ability to manage notifications here obviates managing them on MHV, but I don't know the plans and needs of the stakeholders regarding this.

mtcA6 commented 1 month ago

Take a look at the MHV tabs and not the current/prod designs

image

twoangstroms commented 1 month ago

Thanks. I couldn't tell which were in play/last updated.

mtcA6 commented 1 month ago

@twoangstroms we keep the prod ones up to date/ in step w production since we link to those from our documentation for use cases.

The other in flight items that are behind feature flags are in the other tabs. We migrate that work to the prod tabs when we launch the features.

twoangstroms commented 1 month ago

Ready for review by @mtcA6 and @ACParker89 Link: https://www.figma.com/design/e6JEtrwZCInKk9SjZktx2T/Profile---Notification-Settings?node-id=484-9987&m=dev

twoangstroms commented 1 month ago

Review, iteration, and talking with CAIA will have this ticket rolling to next sprint

mtcA6 commented 1 month ago

cool, thanks for these! I'd say toss that out there on #85845 and get Laura to opine.

ACParker89 commented 1 month ago

Agree with Travis on getting them to give some feedback! Thank you Dan!

twoangstroms commented 3 weeks ago

Documenting a11y constraints:

twoangstroms commented 3 weeks ago

Documenting technical constraints:

ACParker89 commented 3 weeks ago

@tpharrison @asiisii @mtcA6 - planning to discuss this Wednesday in order to discuss BE capabilities to tie in with Design possibilities

mtcA6 commented 3 weeks ago

Trav, Dan, and Autumn Atchley to meet, Travis to schedule a meeting next week.

@clantosswett, I'll set this for maybe Tuesday hopefully we can get an answer back on the timeline from MHV. I think there's still value in us meeting even if the urgency does taper off.

mtcA6 commented 2 weeks ago

Response regarding MHV's priority on this:

Chante said:

@ Travis Cahill as expected, the VA.gov appointments team has not deprioritized the PHI/PII included notifications work. I told them we can let VA profile know but that they might want/need to regroup with MHV folks to get on the same page. I also told them some kind of timeline, even if it is notional (i.e. FY25Q1) would be helpful for us and VA profile. In the meantime, I'll let Mike and Barbie know that the VA.gov appointments team still has this work as a priority and that we will likely need to have another conversation with the various groups to determine when this work is needed by.

there is a call scheduled for Monday, that will focus mainly on the timeline not the functionality.

mtcA6 commented 1 week ago
mtcA6 commented 3 days ago
twoangstroms commented 2 days ago

Updated in Desktop - PHI/PII Notifications After Design Intent

mtcA6 commented 1 day ago

@asiisii could you create the FE ticket that's needed to actually implement the design Dan shared? I need you to be deeply critical of the designs here and think about what you genuinely need when you go to build this on the FE. If we need more info from design we should make sure we get that now

@twoangstroms some thoughts:

  1. can we combine/reduce the number of working tabs related to PHI/PII in the figma file?
  2. do you have mobile designs, I've heard stated before we're mobile first and should consider mobile ahead of desktop.
  3. in you coordinating with @mattmarino-adhoc on best practices, I think when we get to a finalized design it would be great to break down the design with notes and details similar to what was done here
  4. once you've got mobile designs, I think this ticket is good to close - if we need to rework wording then we can create a new ticket for a future sprint but I think we won't really be able to make more progress here until we get data from VA Profile (PoC Autumn)

Related to PHI/PII work but not related to the AC of this ticket, we've expressed the desire to submit the final design through the experimental design process, I think it would be informative to look at a prior example here because I don't know that our designs are going to meet the level of scrutiny that process requires. The below example was approved and we're waiting for it to be built by the design system.

twoangstroms commented 1 day ago

@mtcA6 Hear you on mobile. Hoping to get some info from the DS team (or whether I should connect with the Mobile (big M) team) to clear up some potential issues in this pattern.

By "working tabs", do you mean what Figma calls Pages (I know, all the proprietary terms are confusing; Matt and I hope to disambiguate)?

mtcA6 commented 1 day ago

We already connected with Mobile and Ryan Thurlwell gave a thorough signoff here for us to move forward

twoangstroms commented 1 day ago

Thanks for the link. I was thinking someone who is working on the web product would be better for signing off on a pattern for the web, but we can refer back to Ryan.

twoangstroms commented 1 day ago

Dan Brady (Design System) gave the nod.

asiisii commented 1 day ago

Here's the FE ticket for this enhancement https://github.com/department-of-veterans-affairs/va.gov-team/issues/92656

cc: @mtcA6 @twoangstroms