department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Staging Review finding: Inconsistent H1 text for details pages #86219

Open shiragoodman opened 4 months ago

shiragoodman commented 4 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: MHV Product: Medical Records Feature: Lab & Test

Findings details

VA.gov Experience Standard - issue: User encounters content with errors or inconsistencies. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @erinrwhite (IA)

Description

H1’s for details pages vary and are not consistent.

This is both an inconsistency issue across the sections of the app, and also creates issues on the vaccines, allergies, and health conditions details pages where the first part of the tag does not match the H1, per the IA spec.</p> <h2>Recommended action</h2> <p>Pick one standard for the details pages' H1’s and implement it. Where possible, ensure the text of the H1 of the page and the first part of the page’s <title> tag are the same.</p> <h2>References</h2> <ul> <li><strong>Accessibility Defect Severity:</strong> N/A</li> <li><strong>WCAG Success Criteria:</strong> N/A</li> <li><strong>Modality:</strong> N/A</li> <li><strong>Design System Component:</strong> N/A</li> <li><strong>Design System Pattern or Template:</strong> N/A</li> <li><strong>Design System Foundation:</strong> N/A</li> <li><strong>Content Style Guide:</strong> <a rel="noreferrer nofollow" target="_blank" href="https://design.va.gov/content-style-guide/page-titles-and-section-titles">Page titles and section titles</a></li> <li><strong>Context:</strong> Headings</li> </ul> <hr /> <h3>Next Steps for the VFS Team</h3> <ul> <li>[ ] <strong>Questions?</strong> For the most timely response, comment on Slack in your team channel tagging <code>@platform-governance-team-members</code> with any questions or to get help validating the issue.</li> <li>[ ] <strong>Ticket ownership:</strong> If you believe that this issue is out of scope, not your team's responsibility, or a Design System issue, comment and tag <code>@platform-governance-team-members</code> on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.</li> <li>[ ] <strong>Close this ticket</strong> when the issue has been resolved or validated by your Product Owner.</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bryan-riley-va"><img src="https://avatars.githubusercontent.com/u/105732252?v=4" />bryan-riley-va</a> commented <strong> 3 weeks ago</strong> </div> <div class="markdown-body"> <p>MHV-59187</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>