Closed humancompanion-usds closed 1 month ago
This issue is stale. If it is no longer valid, please close issue. Otherwise please update
Closing. This has been addressed and a postmortem has been filed here. Follow on work for the injected header has removed the dependency that initially caused this.
Instructions
Please fill out the necessary details and list the PRs related to the OOB deployment in the sections below.
PRs Related to OOB
https://github.com/department-of-veterans-affairs/component-library/pull/1202 https://github.com/department-of-veterans-affairs/vets-website/actions/runs/9652631669
Active Daily Users Impacted
The extra padding impacts all users of tier 2 sites such as the NCA site where the problem was first reported.
Has fix been confirmed in Staging?
It's only impacting Teamsites which we cannot properly test in Staging.
Description
A CSS change to va-alert somehow leaked into main.css via the injected header impacting all paragraph tags on tier 2 sites (i.e. unmodernized parts of VA.gov). This causes extra padding top and bottom of 1em.
Verify The following
This issue was escalated to Charles and both Sitewide and Design System teams were tasked with figuring out a solution. The solution was not identified before the 2pm cut off. Due to the widespread nature of the problem and the user visibility of the problem we decided an OOB deployment was necessary.
[^1]: (See Deployment Policy and Deployment Schedules
Performed by Platform Support Team
/pd trigger
[ ] Security Team has Reviewed the requests
CC: @department-of-veterans-affairs/vsp-operations , @department-of-veterans-affairs/vsp-product-support