department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 202 forks source link

Staging Review finding: Missing headings #86830

Closed shiragoodman closed 1 month ago

shiragoodman commented 3 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: VYE Team Product: Verify Your Enrollment Feature: Verify Your Enrollment

Findings details

VA.gov Experience Standard - issue: User can't determine next steps in a flow. VA.gov Experience Standard - category: Findability Launch-blocking: No Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

On /mgib-enrollments/benefits-profile/, the "Pending documents" text is styled to look like an H2 heading but is coded as a p paragraph. Likewise, after submitting an enrollment verification, the success alert is styled as having a heading but the heading itself is just coded as a div.

Screen reader users often navigate the page via heading, in which they skip directly to the heading for the section of content they're looking for. When heading text isn't coded as a heading, it's not available for them as a navigational tool.

Link, screenshot or steps to recreate The two examples identified are currently coded as: ```

Pending documents

``` and ```
You have successfully verified your enrollment
```

Recommended action

Both of these should be H2 headings.

References


Next Steps for the VFS Team

wafimohamed commented 1 month ago

done with this issue https://github.com/department-of-veterans-affairs/vets-website/pull/31687