department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
277 stars 194 forks source link

Staging Review finding: Button is mis-identified to screen reader users #86832

Closed shiragoodman closed 1 day ago

shiragoodman commented 1 week ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: VYE Team Product: Verify Your Enrollment Feature: Verify Your Enrollment

Findings details

VA.gov Experience Standard - issue: User can't identify an element or its state. VA.gov Experience Standard - category: Usability Launch-blocking: Yes Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

On /mgib-enrollments/benefits-profile/ when editing contact information, the Cancel button has an aria-label that misidentifies its purpose. Although the interaction is for contact information, the button is announced to screen reader users as "cancel updating your bank information for GI Bill benefits."

Link, screenshot or steps to recreate Here's that button group as currently coded: ```
```

Recommended action

Guessing this was a copy/paste error, but make sure the aria-label always matches the actual purpose of the element.

References


Next Steps for the VFS Team

jsimonVA commented 1 week ago

aria-label has been updated https://github.com/department-of-veterans-affairs/vets-website/pull/30534

jsimonVA commented 2 days ago

Update has been made and is in staging.