Closed laurwill closed 1 week ago
@laurwill Thanks for creating the ticket and alerting us! I'll get this poised to possibly be pulled into the sprint starting today, if there's room and the team can async refine it. cc @jilladams @mmiddaugh
@chriskim2311 @dsasser I'm not sure if this is an FE or Drupal ticket, and was wondering whichever it is, can one of you async refine it sometime this week so that we can have it in Stretch/Next Sprint as a possible stretch goal for Sprint 7? Thanks!
Engineering notes:
Once the CMS changes are done by Tim, the work is 100% FE, and involves:
Overall I would point this work at a 5 (3 for the dev work and a 1 or 2 for testing/qa).
PR has been merged that creates the necessary menu in config: https://github.com/department-of-veterans-affairs/va.gov-cms/pull/18395
cc @kristinoletmuskat for awareness of left nav process :)
Added an AC here to get Laura Willwerth's explicit review /signoff in tugboat before this ships.
I built the left nav menu in Drupal, so it's ready for testing: https://prod.cms.va.gov/admin/structure/menu/manage/family-and-caregiver-benefits
Hi @jilladams , I'm OOO next week 7/1-7/5, so if this fix happens while I'm out, @kristinoletmuskat will be available for review/signoff of the left nav in Tugboat.
Neither of us have used Tugboat before—is this something we can review over a screenshare?
Thank you again so much for your help with this!
Yes, we realized yesterday that y'all won't have Tugboat access without SOCKS so we can provide screenshots (or do a screenshare), either way. (FYI @kristinoletmuskat )
Status: PR is up and I have a Tugboat setup with the changes applied there.
A couple things to note:
Hi @dsasser , thank you so much for these screenshots!
To confirm, that Second Level menu item (Get Benefits) -- we have to have that?
Here is the nesting we were going for in the first section, health and disability benefits. So other than what you have above, we also need an 'Apply now' link that links to the PCAFC form (which does not live in drupal)
The breadcrumb is part of an ongoing issue documented in this PW ticket.
@jilladams FYI the broken breadcrumb is appearing in this tugboat instance, looking like it might impact all the pages in the structure? Based on the screenshots above, it seems like the new left nav rollout could mess up ALL of the breadcrumbs, potentially. So I’m thinking we wait until PW has resolved the breadcrumb issue before rolling out a new left nav. Thoughts?
@kristinoletmuskat
To confirm, that Second Level menu item (Get Benefits) -- we have to have that?
Yes that level is required. It doesn't need to be named 'Get benefits' however. Similar hub menus have 'Get benefits', 'Manage benefits', and 'More resources' at that level. See https://staging.cms.va.gov/admin/structure/menu/manage/disability-benefits-hub.
@dsasser we can use 'get benefits' for that second level for now!
I changed the menu in production, adding the 'Get benefits' level, and disabling the 'Apply now' link:
Thank you for adding the 'Get Benefits'! We do want the 'apply now' to be nested under the Program of Comprehensive Assistance for Family Caregivers -- are you able to nest that in there @dsasser ?
Thank you for adding the 'Get Benefits'! We do want the 'apply now' to be nested under the Program of Comprehensive Assistance for Family Caregivers -- are you able to nest that in there @dsasser ?
Yes! Is this what you are after?
@dsasser yes! And then the spanish link -- that will only show if the toggle is selected, right? I know we had another ticket for the spanish toggles here: https://github.com/department-of-veterans-affairs/va.gov-team/issues/84625
@kristinoletmuskat that is correct, once https://github.com/department-of-veterans-affairs/va.gov-team/issues/84625 ships the Spanish toggle will be displayed and the Spanish link along with it.
This is how things will look until the Spanish toggle work is complete:
Ok! Let's hold the left nav until the spanish toggle ticket is finished.
@kristinoletmuskat clarifying: it seems like the requirements in this ticket are met, and the left nav is appearing in Prod. e.g.: https://www.va.gov/family-and-caregiver-benefits/health-and-disability/
I would like to close this, and track any further updates related to translation in that other ticket https://github.com/department-of-veterans-affairs/va.gov-team/issues/84625. Does anyone on here (@kristinoletmuskat @dsasser ?) object?
Yes that's fine! @jilladams
Indicate if you need front-end engineering support for
Describe your request
We published the new family and caregiver benefits hub page and related child pages on Monday 6/24. Tim Cosgrove from CMS team is creating a new menu for this hub, so that we can assign the child pages to the intended left nav structure.
Now we need PW help to understand and complete any other steps needed to make the left nav display in the new hub.
Time constraints / launch deadlines
The pages are already live and redirects are happening tomorrow 6/25, so as soon as you can fit this in, but we understand this is an unplanned request. Apologies for not opening this earlier, I very much underestimated the work needed to set up a new hub.
Your product/team Slack channel
sitewide-content-accessibility-ia
THREAD: Use this thread for comms with CAIA: https://dsva.slack.com/archives/C01K37HRUAH/p1719332572216609
Your OCTODE product owner
Danielle Thierry
ACs