department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

10-10d: create feature toggle and react widget ID #86998

Closed baltes closed 3 months ago

baltes commented 4 months ago
michaelclement commented 4 months ago

Initial work is done in these three PRs. Order is this:

  1. [x] This vets-api PR needs to be merged
  2. [x] This vets-website PR needs to be merged
  3. [x] This other vets-website PR needs to be merged

Once that's accomplished we should be able to view and interact with the toggle by going to https://staging-api.va.gov/flipper/features/form1010d

michaelclement commented 4 months ago

Based on this document, the react widget is a small widget we will add to a Drupal static page (which is yet to be created). This will be the jumping off point where veterans will access our form to begin with.

Getting this set up will require additional PRs in three repos: vets-website, content-build, and vagov-content

@reiting - does this track with your understanding? I'm pretty sure I see what we're doing but just want to double-check.

Edit: The process for creating the static page may not not require using vagov-content repo, per this doc

michaelclement commented 4 months ago

React widget ID: form1010d

michaelclement commented 3 months ago

I put together a request for UI access so I can edit the flipper in production. Waiting on approval.

michaelclement commented 3 months ago

All PRs were merged and flipper is visible in the admin UI on staging here (search on the page for form1010d)

I'm still waiting on my access request to be approved, so until then we can't actually toggle the flipper.

michaelclement commented 3 months ago

@baltes @marywang2 @reiting - if you'd like to get access to the flipper UI to enable/disable forms you'll need to fill out a ticket like mine - here's the link to create a new one.

michaelclement commented 3 months ago

@baltes @marywang2 @jamiefiore This is ready for you to take a look at - if you visit 10-10d on staging you'll see that it's blocked by a feature flipper. Thanks!

michaelclement commented 3 months ago

@baltes It's not currently blocked because we needed to look at the form, but let me know when you want to review this and I can walk you through it. Thanks!

baltes commented 3 months ago

Hi @michaelclement , I see the block but then it hops to the intro page. Just wanted to make sure this is expected. Video of page load

michaelclement commented 3 months ago

@baltes Yep, that happens because it first has to check if the form is enabled and that check takes a second -expected behavior