Update Governance process for DST Staging Reviews

[shiragoodman]

User Story

As an accessibility specialist supporting Governance team and the Collaboration Cycle, I want to update/modify the process I follow at Design System Staging Reviews so that it includes my responsibilities for upholding the Accessibility Testing Plan and updating the accessibility component checklist, if needed.

Assignee: @briandeconinck Peer Reviewer:

Description

Governance and DST have finalized their accessibility testing plan for VADS components, and have determined how the accessibility component checklist will be updated for each component change, prior to the Staging Review. The purpose of this ticket is to update the operational process that Governance follows for completing a Design System Staging Review.

Impacted Artifacts

Live pages

Drafted pages

• How to complete an Accessibility review for Design System staging review

Tasks

• [x] Write internal guidance on how to complete an accessibility review for design system components.
  • Should be consistent with:
    • The accessibility testing plan defined earlier in this initiative
    • The division of testing responsibilities agreed to between Governance and DST
    • Existing documentation for accessibility reviews of VFS products

Peer Review

To be completed by peer reviewer

• [ ] User story and acceptance criteria are met

Acceptance Criteria

• [x] The Governance operational process for supporting a Design System Staging Review has been updated to align with the Accessibility Testing Plan
• [x] The Governance operational process for supporting a Design System Staging Review has been updated so that changes to the accessibility component checklist are documented as as Staging Review finding.

Team Notification

• [ ] Slack post on #platform-governance-team
• [ ] Presentation at Weekly Initiative Meeting
• [x] No notification needed

How to prepare this issue

Refinement

• [x] Ticket has user story, description, tasks, and acceptance criteria
• [x] Ticket has been sized
• [x] Once all above items are checked, add the 'Ready' label.

  Planning

  If this ticket is picked up from the Backlog mid-sprint, connect with Shira to ensure the below items are completed correctly

• [x] Ticket has been discussed as a team at Planning
• [x] Ticket has been assigned to appropriate initiative or quarterly epic
• [x] Ticket has been assigned to a Sprint
• [x] Ticket has been moved to the Planned pipeline in the Governance team board
• [x] Ticket as an assignee and peer reviewer

[rsmithadhoc]

@briandeconinck One thing I'm thinking of for a testing doc (started something in https://github.com/department-of-veterans-affairs/vets-design-system-documentation/pull/3071/files), is how much detail we go into for each one. For example:

• Keyboard compatibility - should we detail each subcategory:
  • Tab order - the tab order follows a logical sequence that matches the visual layout.
  • Focus indicator - that focus indicators are visible and clearly indicate which element is currently focused.
  • Interactive elements - (blurb about that)
  • Etc.

Or do we outline a testing procedure:

• Keyboard compatibility
  • Tab through the page - (sentence or two about what to look for)
  • Activate page elements - (sentence or two about what to look for)
  • Navigate within elements - Arrow keys, etc. (sentence or two about what to look for)
  • Modals - Keyboard trap within, etc. (sentence or two about what to look for)

Or both? - here's what we look for, plus here's the procedure we follow to do that.

[briandeconinck]

Created internal guidance for Governance team, mostly repurposing existing documentation and then adding some extras just for VADS components. I think I'll want to review/refine a few times as we test components but I think this is a solid MVP.

No peer reviewer assigned and this is really just for my use at this time, so closing as complete.