department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[VETS-API] Bump rack gem 2.2.9 -> 3.1.4 #87291

Open ryan-mcneil opened 4 months ago

ryan-mcneil commented 4 months ago

Issue Description

Rack is due for a significant update, including a major version bump. There's a Dependabot PR with a TON of broken specs. This might need some thoughtful attention

Requirements to update rack to 3.1.4 (in vets-api):

NOTES:


Tasks

Acceptance Criteria

ryan-mcneil commented 4 months ago

Duplicates #74448, but we'll use this one

ryan-mcneil commented 3 months ago

TL;DR - We want to update to Rack 3+, which requires httpi 4+, but two of our gems (bgs_ext and connect_vbms) are holding it back.

I started investigating, and realized that at least one of the errors is due to a constant that was removed in rack 3 is being used in our current version of httpi (2.5), which is held back by savon 12.1 which is in turn held back by us having so far been able to bump to the latest bgs_ext release which would get us to savon 14.0 and httpi >= 2.4.5. UPDATE: httpi is ALSO held back by connect_vbms. I'll talk to Steven about bumping the dependency in his fork.

The following errors are because of httpi/savon:

We'll block this for now, as it doesn't make much sense to explore the 300+ errors if a lot of them could be caused by the same thing

ryan-mcneil commented 1 month ago

The following ticket clears up ~120 of the ~400 failing tests: #93388