department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Image placement within document could be confusing for some users #87429

Open shiragoodman opened 2 months ago

shiragoodman commented 2 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Sitewide Facilities Product: VBA Regional Offices Feature: Site Modernization

Findings details

VA.gov Experience Standard - issue: User encounters design components or patterns that are inconsistent or confusing. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

In the "Location and contact information" section, here's where the images of the facility and the map are placed:

This potentially impacts users in a couple of ways:

The actual impact here is relatively minor --- the two images in the right-hand column aren't critical to understanding the page. But it's still a potential point of friction.

Link, screenshot or steps to recreate The two-column layout is coded roughly as: ```

Location and contact information

[all of the text]
[both images]
``` ... with CSS stacking the second `div` on top of the first `div` for small viewports. Screen readers will read top to bottom regardless of CSS positioning.

Recommended action

Preferred option would be to explore some CSS layouts that keep the images in in the same chunk of content as the address and "Get directions on Google Maps" text. That's what they're most closely related to, that's where it makes sense for them to be.

Next-best option would be to flip the order:

<h2 ...>
   Location and contact information
</h2>

<div ...>
   <div ...>
      [both images]
   </div> 

   <div ...>
      [all of the text]
   </div>         
</div>

... with CSS to float the images to the right. It's not ideal but I think it would be an improvement overall. That would ensure the document order and screen reader experience would match the small viewport experience, and keep both of those images in pretty close proximity to their related content.

References


Next Steps for the VFS Team

jilladams commented 3 weeks ago

Tracking in https://github.com/department-of-veterans-affairs/va.gov-cms/issues/18268