FE/BE Pair - Discovery - getCalculatedMonthlyIncomeApi failed in helper:

[amponce]

Discovery FE/BE pair investigation

Sentry Error

We're seeing an error in sentry that originates from the Additional Income List

getCalculatedMonthlyIncomeApi failed in helper: Error: No value destructured in response from getCalculatedMonthlyIncomeApi calculateTotalAnnualIncome

Acceptance Criteria

• [x] Scenario: Successful calculation of monthly income
  • Given the input data is valid and complete
  • When the API call is made to calculate the monthly income
  • Then the response should contain a calculated monthly income value without any errors

[OptionSelect]

Ongoing discussion in debt-devs-internal here in which suggested solution is BE null check added to the total_monthly_net_income variable calculation in income_calculator.rb in API section.

[OptionSelect]

BE PR was merged here. Still testing on our end and monitoring sentry but this should fix this.

[OptionSelect]

FYI the BE PR has yet to be deployed. Still monitoring. No luck reproducing in staging or locally still. I'd like to think we're ok.

[Tom-Davis]

@OptionSelect can you move this to the proper column state (Maybe closed?)

[OptionSelect]

Sorry, still not closed. Rolling due to not having a backend deployment by our devops team since last week. The code change has yet to reach production for us to verify we no longer see the error.

[OptionSelect]

Cant tell if this has been deployed correctly as we are still seeing issues in sentry. Andrew raised concern about calculation so are back to diving in on this as!

[Dr-Pongo]

Heyoo, just wanted to drop some updates on this ticket! A portion of these errors may be false positives being caused by a falsy check when destructuring the response from the endpoint. We included a fix that got merged today and should take effect after the deploy. The error message text has changed so we'll need to keep an eye out for the new error:

No value destructured in response from getCalculatedMonthlyIncomeApi in checkIncomeGmt

Going to move to validate until the end of the week as we monitor Sentry

[Dr-Pongo]

New error handling and income api calls seems to be clear in sentry. Saw a small single error pop, but does not appear to be indicative of a larger problem we can address. Closing out now that error handling is more robust!