department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Fix code coverage #87779

Closed asg5704 closed 1 month ago

asg5704 commented 1 month ago

Description

The code coverage standards currently only applies to applications within vets-website repository and does not include the platform directory in that requirement. Our team should be the standard when it comes to code coverage in platform code.

Tasks

Create a ticket for each of the tasks listed below (reference this ticket and the one created for the tasks in your PRs). Fix code coverage for the following components and utilities

How to check code coverage

  1. Run yarn test:unit <location-of-unit-test> --coverage --coverage-html
  2. Open up the coverage/index.html file in a browser
  3. Verify code coverage minimums and refactor as needed
asg5704 commented 1 month ago

@acaruso-oddball I added both Caitlin and Ian on this as well. This is the ticket I mentioned that would be a mini-epic and separate tickets will need to be created for each of those files/components.

cc @CaitHawk @ianmagenta

parkerbees commented 1 month ago

Copied to jira, closing here