department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Migrate 21a into ARP #87799

Open williamphelps13 opened 2 months ago

williamphelps13 commented 2 months ago

Description

Problem Statement

Implementation Details

Mockups/Designs

https://www.figma.com/design/2afIGOMII0uRI5ck1dWo1w/Form-21a---Apply-for-Accreditation-(CA-%26-Attorneys)?node-id=1026-23113&t=jRgivAFabaQuJxHs-4

Acceptance Criteria

Automated Testing

williamphelps13 commented 1 month ago

Draft PR: #30835 87799 ARF migrate 21a into ARP (vets-website)

Next step in completing PR is around making Save in Progress work with the ARP frontend (which is technically a different Zenhub issue but it seems to need to be done in this PR because it is blocking the form from rendering)

nihil2501 commented 1 month ago

@williamphelps13 tweak PR into yours of a basic error in the reducer structure we were returning. this should unlock the next more challenging phase of integrating SIP. see PR description.

williamphelps13 commented 1 month ago

I picked up this issue because I had bandwidth for the 1-2pt issue that it was initially given but with the 4 form library fix issues I currently own (minItem validation and yes/no, address field, and date field fixes) and upcoming align steps with V3 design issues it seems best to pass this now 3-5pt issue to someone with more open bandwidth. Oren also created the initial POC that proposed using startReactApp instead of the standard startApp, but then he got pulled into Lighthouse before being able to implement it. The complexity of this issue is in this space.

After discussion with him and Gabe, Oren will take ownership of this issue and its PR (links are to the PRs themselves):

gabezurita commented 1 month ago

@nihil2501, @HaroldLee-VA, and @a6marinos, here's the issue that will likely be resolved by this work: https://app.zenhub.com/workspaces/accredited-representative-facing-team-65453a97a9cc36069a2ad1d6/issues/gh/department-of-veterans-affairs/va.gov-team/86193