search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 196 forks source link

4 Modifications to Tagalog Content #87810

Closed loripusey closed 19 hours ago

loripusey commented 2 weeks ago

Description

We received feedback from the State Department for our recent Tagalog translations.

List of Modifications

  1. Highlighted text until … “personal,” should not be in bold per source

    image.png

  2. All dates should be in Tagalog (see this reference)

  3. Highlighted text needs to be “pagkakakulong”

    image.png

  4. Highlighted text needs to be “tinatanggap”

    image.png
loripusey commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @brianseek @wullaski

wullaski commented 2 weeks ago

@loripusey I can't see the images in the description.

wullaski commented 2 weeks ago

@brianseek I'm looking at our date i18n utility and it looks like we are only doing English and Spanish. Was there a reason for that? My estimate could be off since I'm not sure what the level of effort will be to add Tagalog to that utility.

loripusey commented 2 weeks ago

I'll paste the images in Slack, I see them

brianseek commented 21 hours ago

I spent some time focused on just the date element of this. Our application uses date-fns locales to accomplish our date translations. The problem is that there is no Tagalog locale in the library. There have been a couple of issues to add it, but no traction. https://github.com/date-fns/date-fns/issues/1208 https://github.com/date-fns/date-fns/issues/3343

We could add one our selves and open a PR to have it added and patch it in the mean time. But we would need to setup the module then work with the state dept. to a get full set date translations. This would be a decent sized lift.

Still looking into alternative options that just cover the few date scenarios that we use.

brianseek commented 20 hours ago

@loripusey The text update portion of this work is ready to validate in the following screenshots:

localhost_3001_health-care_appointment-check-in_travel-vehicle.png localhost_3001_health-care_appointment-check-in_travel-vehicle (1).png
loripusey commented 20 hours ago

Looks good to close.

brianseek commented 19 hours ago

closing this ticket, code review and merging to take place in this ticket for next sprint: https://app.zenhub.com/workspaces/check-in-experience-61fc23a2cb8a14001132e102/issues/gh/department-of-veterans-affairs/va.gov-team/88841