department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Use va-select component instead of imposter component #87888

Closed shiragoodman closed 1 month ago

shiragoodman commented 1 month ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: VA BTSSS - Travel Pay Product: Travel Pay Feature: MVP

Findings details

VA.gov Experience Standard - issue: User encounters a component or pattern that isn't considered a best practice. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @it-harrison (QA)

Description

The select element used to select select the order of appointments (i.e. "Show appointments in this order") is not rendered with the va-select component

Recommended action

Use the va-select component

References


Next Steps for the VFS Team

kjduensing commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @athifw @hinzed1127

ayush-chak commented 1 month ago

Confirming that this is complete - leaving all open until review