Updates to 10-10d notification emails

[baltes]

As a CHAMPVA applicant, I need info about my files that were received by VA and other helpful guidance in my email notification.

Acceptance criteria

• As an applicant I get one confirmation email per submit rather than one per file
• As an applicant I can see how many supporting docs were included with my application.
• As a VA-notify template editor I have a key for submit date to include rather than date updated

This is a task to update variables for the 10-10d VA-notify template.

Below is an example from form 10-10EZ that we can borrow from.

Here's what we currently have in our template:

Change the metadata key for ((updated_at)) to ((date_submitted)) so that it's clear that it's the date the form is submitted rather than a different update date.

Add a variable with a count for all supporting documents update that does not include the form itself. The user should see something to the effect of "We've received your form 10-10d and the X supporting documents you provided." We'll need a variable we can use in VA-notify to populate X.

Add a form name variable for use in VA-notify along with the existing for number. Use names as shown below:

Form number	Form name
10-10d	Application for CHAMPVA Benefits
10-7959a	CHAMPVA Claim Form
10-7959c	Other Health Insurance (OHI) Certification
10-7959f-1	Foreign Medical Program (FMP) Registration Form
10-7959f-2	Foreign Medical Program (FMP) Claim Cover Sheet

Add variable for call center phone number so that we can add a key for either the CHAMPVA number or the FMP number.	program	call center number
Foreign Medical Program (FMP)	877-345-8179
Civilian Health and Medical Program of the Department of Veterans Affairs (CHAMPVA)	800-733-8387

[balexandr]

First PR is for updates to the data model https://github.com/department-of-veterans-affairs/vets-api/pull/17651

[balexandr]

Second PR was merged https://github.com/department-of-veterans-affairs/vets-api/pull/17655

[balexandr]

Third PR with email fix and phone_number https://github.com/department-of-veterans-affairs/vets-api/pull/17667

[balexandr]

@baltes form_name, file_count and phone_number have been added to the email template

[baltes]

@balexandr Can you double check the file count and confirm that it is only for supporting docs, not including the form itself?

This submit was for one applicant, with one file for marriage license, two files for insurance cards, and one file for OHI.

[balexandr]

@baltes It includes the form itself as it is still considered a file that's being processed. I can change it to pass "0" along to the template so it says 0 supporting documents received. I don't see a way to conditionally hide the "File Count" bit in the template if it's 0 FYI.

[baltes]

@balexandr It was always meant to be a count of supporting documents that doesn't include the form itself. No need to hide it if the count is zero.

[baltes]

@balexandr We still need the count changed so that it covers supporting docs and doesn't include the form. Let me know if we need to break that into a separate ticket.

[balexandr]

@baltes So right now it's doing the count based on the form_uuid so if there are multiple applicants with multiple PDFs for the form it will be all those minus the main one. Is that good? I'm basically putting in logic to take the entire count and subtract 1

[baltes]

@balexandr The goal is to tell the user "we received your application and X supporting documents." The user shouldn't have to be aware that we generated multiple form PDFs--it's just one application as far as they're concerned.

I'll close this ticket and break that part out into a new one if that makes sense at this point.

[balexandr]

That's okay I think I got it

[balexandr]

Another PR in review for this change https://github.com/department-of-veterans-affairs/vets-api/pull/17770

[balexandr]

@baltes I did a submission with a birth certificate and front and back of medicare cards