Closed jennb33 closed 1 month ago
Exceptions to requiring a review from backend-review-group: identity, mobile, and lighthouse.
7/25 update: Per @rjohnson2011 this is moving forward. We need to make a GHA that requires feedback and possibly group approval on all PRs minus identity, mobile and lighthouse.
7/29 update: @rjohnson2011 has the GHA written out, now we need to review it with VFS teams.
User Story
As the developers and managers on the Platform, We need to implement the GHA workflow So that we will have a consistent backend review process and avoid potential deploy blockers.
Issue Description
See the Slack thread here from DSVA.
We have been waiting for the bandwidth to change the conveyor belt to prod flow before adding be-review-group to the team PR approvals. However, a change was released to prod that logs sensitive data to Datadog (and the overall design was poor). It's in the vye module, so it didn't require code review. These kinds of releases need to be avoided; it would be best to implement the GHA workflow and ensure a consistent backend review process.
Tasks
Success Metrics
Acceptance Criteria
[ ] There will be a more consistent and smooth approval process, ensuring that things are not missed.
Validation
Assignee to add steps to this section. List the actions that need to be taken to confirm this issue is complete. Include any necessary links or context. State the expected outcome.
*Not all PRs, This process is not required for all Identity, Mobile, Lighthouse PRs