department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Improve backend transform output consistency #88280

Closed maxx1128 closed 1 month ago

maxx1128 commented 1 month ago

Issue Description

For the backend transform files in modules/debts_api/lib/debts_api/v0/fsr_form_transform, there's some inconsistency in the output hash objects that make the classes less readable and are a minor code smell. Some output a full hash object, such as gmt_calculator#income_limits. Others start with an empty one and build on it, such as asset_calculator#transform_assets. Virtually all cases could go with the former.

Back end tasks

Acceptance Criteria

Appendix

Product notes

Tech notes


How to configure this issue

maxx1128 commented 1 month ago

As of the end of Sprint 129, this ticket's pull request needs to be approved before it is ready to merge. However, we're concerned that merging it will negatively affect testing. So, we're holding off on the final merge even after it is approved.