department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Toxic Exposure: Prepare artifacts for PSIRR #88404

Closed pacerwow closed 2 weeks ago

pacerwow commented 1 month ago

Issue Description

As a VA Platform I want to ensure that the toxic exposure feature meets Platform's privacy and security standards so that it can be released successfully while protecting the safety of Veterans and VA.gov.


Tasks

Acceptance Criteria

Given the artifacts to successfully complete a PSIRR request form are needed When the artifacts or documents are not created or complete Then create necessary documentation and/or artifacts for the request form and submit it to Platform


How to configure this issue

pacerwow commented 1 month ago

I can submit the ticket, will need everyone's help in making sure the artifacts are created & current.

mchae-nava commented 4 weeks ago

Working on the metrics portion of this

aurora-a-k-a-lightning commented 3 weeks ago

working on these parts:

  1. An architecture diagram, showing involved systems and how they connect.
  2. For non-trivial flows (i.e. more than a single round-trip call from frontend → vets-api → VA Backend), a sequence diagram showing the ordered flow of data and operations between systems.
  3. Describe any new interactions with dependent VA backends
pacerwow commented 2 weeks ago

TE Product Outline: https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/disability/526ez/toxic-exposure-initiative-brief.md

aurora-a-k-a-lightning commented 2 weeks ago

Architecture diagram https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/disability/526ez/engineering_research/diagrams/DBex%20Diagrams%20-%20%2388404%20-%20PSIRR.jpeg

aurora-a-k-a-lightning commented 2 weeks ago

For this: Describe any new publicly-exposed endpoints We have none.

aurora-a-k-a-lightning commented 2 weeks ago

For this: Describe any new interactions with dependent VA backends We have new interactions with the Lighthouse Benefits Claims APIs as described in the Architecture diagram:

  1. https://api.va.gov/services/claims/v2/veterans/:veteranId/526/synchronous - submits the Form 21-526EZ data for claim establishment within VBMS
  2. https://api.va.gov/services/claims/v2/veterans/:veteranId/claims/:id - gets information about a claim
  3. https://api.va.gov/services/claims/v2/veterans/:veteranId/526/generatePDF/minimum-validations - generates a Form 21-526EZ 2022 PDF

All are using the pre-existing Client Credentials Grant (ccg) authentication mechanism with Lighthouse.

aurora-a-k-a-lightning commented 2 weeks ago

For this: Describe any other security hotspots you're concerned about / want extra attention on We don't have any. We're using pre-existing connections and libraries within vets-api.