Closed shiragoodman closed 2 weeks ago
@ldelacosta I'm good with Brian's rec to remove the aria labels from the buttons he noted.
Appointments FE ticket for reference #88523
@shiragoodman - We addressed the ticket in 88523. Let me know if you find additional issues. Thanks!
@briandeconinck FYI
@ldelacosta do you want our help validating the fix?
@shiragoodman - we have validated on our end. If you want to double check, feel free.
This one is complete, we removed the aria labels. Closing (please reopen if I missed anything!)
Need help? Please review how to read a Staging Review ticket. Tag
@platform-governance-team-members
on Slack if you need further assistance.Product Information
Team: Appointments Product: Appointments Feature: Appointment Details Redesign
Findings details
VA.gov Experience Standard - issue: User can't perceive an element. VA.gov Experience Standard - category: Comprehension Launch-blocking: Yes Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)
Description
When cancelling a pending appointment, two buttons appear on the page: "Yes, cancel request" and "No, do not cancel." Both of these buttons have the same
aria-label
, "Cancel appointment," meaning both will be announced to screen reader users as "Cancel appointment." Screen reader users won't be able to distinguish between them, meaning:Link, screenshot or steps to recreate
This is on the page that's displayed when you select a pending appointment and then click "Cancel request." The two buttons are coded as: ``` ``` and ``` ```Recommended action
I'm guessing this is a copy/paste error. For these two buttons, the visible text label is fine --- no need for an
aria-label
at all. My recommendation would be to remove thearia-label
entirely on both.References
Next Steps for the VFS Team
@platform-governance-team-members
with any questions or to get help validating the issue.@platform-governance-team-members
on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.