department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Buttons with opposite purposes have the same `aria-label` #88449

Closed shiragoodman closed 2 weeks ago

shiragoodman commented 1 month ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Appointments Product: Appointments Feature: Appointment Details Redesign

Findings details

VA.gov Experience Standard - issue: User can't perceive an element. VA.gov Experience Standard - category: Comprehension Launch-blocking: Yes Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

When cancelling a pending appointment, two buttons appear on the page: "Yes, cancel request" and "No, do not cancel." Both of these buttons have the same aria-label, "Cancel appointment," meaning both will be announced to screen reader users as "Cancel appointment." Screen reader users won't be able to distinguish between them, meaning:

  1. If they do want to cancel their appointment, they have to get lucky and pick the correct button.
  2. If they don't want to cancel their appointment, they don't have a perceivable route to do that.
Link, screenshot or steps to recreate This is on the page that's displayed when you select a pending appointment and then click "Cancel request." The two buttons are coded as: ``` ``` and ``` ```

Recommended action

I'm guessing this is a copy/paste error. For these two buttons, the visible text label is fine --- no need for an aria-label at all. My recommendation would be to remove the aria-label entirely on both.

References


Next Steps for the VFS Team

outerpress commented 1 month ago

@ldelacosta I'm good with Brian's rec to remove the aria labels from the buttons he noted.

ldelacosta commented 1 month ago

Appointments FE ticket for reference #88523

ldelacosta commented 1 month ago

@shiragoodman - We addressed the ticket in 88523. Let me know if you find additional issues. Thanks!

shiragoodman commented 1 month ago

@briandeconinck FYI

@ldelacosta do you want our help validating the fix?

ldelacosta commented 1 month ago

@shiragoodman - we have validated on our end. If you want to double check, feel free.

outerpress commented 2 weeks ago

This one is complete, we removed the aria labels. Closing (please reopen if I missed anything!)

Screenshot 2024-08-16 at 8.27.29 AM.png