department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Directions and phone number links don't match other icon + link instances on VA.gov #88450

Open shiragoodman opened 1 month ago

shiragoodman commented 1 month ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Appointments Product: Appointments Feature: Appointment Details Redesign

Findings details

VA.gov Experience Standard - issue: User encounters content that doesn't match other content on VA.gov. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

When viewing appointment details for an appointment at a physical location, the "Directions" link and the phone number link have an icon next to it. That icon:

  1. Isn't part of the link and isn't clickable.
  2. Has alternative text announced ("Directions icon" and "Phone icon") that doesn't communicate any meaningful information.

That doesn't match similar icon + link elements on VA.gov, eg. the download link in the design system.

Link, screenshot or steps to recreate An example of the directions icon + link as currently coded: ``` ```

Recommended action

I recommend following the design system links as a template to make the icon part of the clickable region, something roughly like:

<a href="...">
        <va-icon icon="directions" size="3"></va-icon>
        Directions
</a>

The srtext isn't necessary in this situation, because any description of the icon will just be duplicative of the link text.

References


Next Steps for the VFS Team

outerpress commented 1 month ago

@ldelacosta the two pieces of work here -

For phone number and directions links in details pages:

I'm not sure if we need to handle each of the 11 or so types of details pages in separate tix? FYI @ryanshaw