Updates to Welcome component [and consume new v3 service for Preferred Name?]

dcloud commented 2 months ago

REFINE: is v3 service ready for us?

Description

User story

As a Cartography team member, I want the Welcome component to display an appropriate <va-icon /> and for the <va-link /> to provide an action name that Datadog can track

Notes

Currently no direct replacement for fas-user icon
Code linter forces replacement of fas icon code when edits are made to the Welcome component
The <va-link /> provides custom GA analytics call
v3 service update: on 9/6 Jennifer Brown confirmed that V3::ProfileInformation::Service is ready for us, and they think preferred name is in there. (Slack DM with Daniel).

Possible tasks:

Figure out appropriate replacement for fas-user icon
Add data-dd-action-name to the <va-link /> to clicks are tracked. \ Alternatively, replace with an <a> element and ensure both Datadog and Google Analytics report the way we want

Acceptance criteria

QA review
A11y review

wesrowe commented 3 weeks ago

@dcloud, FYSA you could help us get a jump on refinement by recording here what we learned about this work (and what it turns out is not getting done for us).

wesrowe commented 5 days ago

I wanted to take this to office hrs on 9/30 but Patrick wasn't in. Will try again 10/7

department-of-veterans-affairs / va.gov-team