Open briandeconinck opened 1 month ago
@briandeconinck what do you think about adding the trigger inside the dropdown list?
My only concern with it being outside the list is that it might not be clear what the state of the list is. For example, if the list says:
Sort by recent locations [Sort]
...it might not be clear that I've already sorted the list, since the button will be active, especially if I have memory issues.
@ldelacosta I created design ticket #88860 to handle this
Next Steps for the VFS team
@platform-governance-team-members
.Thoughts/questions
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
[ ] Should: There have been a bunch of products in recent months that have some kind of filter/sort capability, and we've been converging on a more standardized pattern for how those should work (though not yet anything formalized in the design system). This changes something that already exists in production, but I think your updates here could be an opportunity to bring the filter/sort behavior here into alignment with what other products are now doing.
As currently coded (and reflected in your designs), on Choose a VA location the "Sort facilities" dropdown immediately applies the new sort criteria as soon as the dropdown's selection changes --- and that's all it does. If I'm a screen reader user or a screen magnification user who can't see the list of facilities itself, I don't get any of the visual cues that the list of locations has updated. Instead, I I have to either trust that the change has occurred, or I have the high cognitive load task of comparing what's in the list now with what I remember was their earlier.
In this case, it's not a huge lift to figure it out. But in some other filter/sort scenarios where multiple criteria are applied, it's more challenging to parse out whether anything has happened.
Here's the pattern that other products have adopted and that I would encourage here:
Here's what that gets you:
Hopefully the written explanation makes more sense than whatever I said out loud during the meeting. Please feel free to ping me in Slack if you'd like to discuss this more!
Governance team actions