department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Display VSO / VSO Representative info in "Next Steps" of 21-22 PDF #88987

Closed oddball-lindsay closed 1 week ago

oddball-lindsay commented 3 months ago

Background

We have code in place to generate a completed 21-22 or 21-22a form (#82223), but for the 21-22 we do not yet have the functionality to show the VSO Representative's information (only the VSO) -- we need the frontend to pass that to the backend.

Once the frontend Representative Chapter is built, we'll want to incorporate that VSO Representative information into the PDF download.

Dependent on https://github.com/department-of-veterans-affairs/va.gov-team/issues/92779

Tasks

Acceptance Criteria

opticbob commented 3 weeks ago

The scaffolding for generating a 2122 next steps page is done, next is writing the code to query the old and new tables for rep info with a rep id.

opticbob commented 2 weeks ago

I'm going to use the same method to lookup the org and rep here that I used in https://github.com/department-of-veterans-affairs/vets-api/pull/18877.

opticbob commented 2 weeks ago

The lookups are done and the next steps page is up and running in the PR. I just need to update some tests and clean it up a bit and it'll be ready for review.

opticbob commented 2 weeks ago

All the fixture PDFs were updated, the database lookups are in place and a lot of test data standardization is in this PR. It's now in review.

opticbob commented 1 week ago

https://github.com/department-of-veterans-affairs/vets-api/pull/18857 has merged, this is done.