Staging Review finding: Use the vads-font-size-eyebrow typography token

shiragoodman commented 1 month ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: Pre-Check-in & eCheck-in Feature: New Landing page design

Findings details

VA.gov Experience Standard - issue: User encounters design components or patterns that are out of date. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @allison0034 (Design)

Description

The text "Check-In" is currently nested inside the h1 and is custom coded for the check-in team. This went through experimental design and we have created a token to use now above the h1.

Link, screenshot or steps to recreate

![screen-shot-1](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/53488-Allison-1.png?raw=true) ![scren-shot-2](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/53488-Allison-2.png?raw=true)

Recommended action

Use the vads-font-size-eyebrow typography token

References

Accessibility Defect Severity: N/A
WCAG Success Criteria: N/A
Modality: N/A
Design System Component: N/A
Design System Pattern or Template: N/A
Design System Foundation: Typography
Content Style Guide: N/A
Context: N/A

Next Steps for the VFS Team

[ ] Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members with any questions or to get help validating the issue.
[ ] Ticket ownership: If you believe that this issue is out of scope, not your team's responsibility, or a Design System issue, comment and tag @platform-governance-team-members on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.
[ ] Close this ticket when the issue has been resolved or validated by your Product Owner.

loripusey commented 1 month ago

Please add your planning poker estimate with Zenhub @brianseek

brianseek commented 1 month ago

@allison0034 I ran a fresh yarn install and I still don't see vads-font-size-eyebrow available as a css variable. Is there something else I need to do?

allison0034 commented 1 month ago

@micahchiang @caw310 do you know who can help Brian with the vads-font-size-eyebrow token?

brianseek commented 1 month ago

bump @micahchiang @caw310 @allison0034 Maybe this isn't in prod yet and we can just move this to our backlog for now?

micahchiang commented 1 month ago

Hey @brianseek - sorry I missed the pings on this ticket. The work to add this token isn't in production yet, but it is in our backlog to do.

brianseek commented 1 month ago

Thanks @micahchiang, I'll move this to our backlog too and pick it back up once the token is in.

brianseek commented 1 month ago

@loripusey moving this to tech debt backlog. Also removed from sprint goals

department-of-veterans-affairs / va.gov-team