department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Staging Review finding: Line break in date of birth description (Check if your information is up to date > Date of birth) #89003

Open shiragoodman opened 3 months ago

shiragoodman commented 3 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: Pre-Check-in & eCheck-in Feature: New Landing page design

Findings details

VA.gov Experience Standard - issue: User encounters content with errors or inconsistencies. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: Yes Collab Cycle Reviewer: @kkitagawa-bosch (Content)

Description

In the section where users are asked to confirm their name and date of birth to confirm their identity, there is an errant line break in the text description. Currently the line reads "Please enter 2 digits for the month and day | and 4 digits for the year" where the vertical line indicates a line break.

Recommended action

Remove the extra line break from this content. Line breaks should scale with content as needed

References


Next Steps for the VFS Team

loripusey commented 3 months ago

Please add your planning poker estimate with Zenhub @brianseek

brianseek commented 3 months ago

This is not a line break but width that is set within the DS and out of our control.

Screenshot 2024-07-23 at 8.12.34 AM.png Screenshot 2024-07-23 at 8.13.03 AM.png
loripusey commented 3 months ago

I sent a Slack message to the platform-design-system channel

shiragoodman commented 3 months ago

@loripusey @brianseek is this for a specific DS component? I'd like to make sure it's tagged. ty!

caw310 commented 3 months ago

DST ticket to fix the bug with va-date component. https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/3061

brianseek commented 3 months ago

this is for the memorable-date component https://design.va.gov/components/form/memorable-date