department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Staging Review finding: "Check in now" links not announced the same way by screen readers #89009

Closed shiragoodman closed 3 months ago

shiragoodman commented 3 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: Pre-Check-in & eCheck-in Feature: New Landing page design

Findings details

VA.gov Experience Standard - issue: User is uncertain where a button or link leads. VA.gov Experience Standard - category: Comprehension Launch-blocking: Yes Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

On /appointment-check-in/appointments, there are two "Check in now" links --- one in the "What to do next" card and one in the "Today's appointments" calendar.

In each place, I am assuming from context that it's possible for more than one appointment to be listed. In the "What to do next" card, the "Check in now" link has an aria-label to clearly identify which appointment you're checking in for. But in the "Today's appointments" section, there's no aria-label on the link.

This could be confusing to screen reader users, who may interpret these links as serving different functions (eg. "check in for the next appointment" and "check in for all of today's appointments").

Link, screenshot or steps to recreate ``` Check in now ``` versus ``` ```

Recommended action

I think the context given by the aria-label makes sense here and would be useful for both of these links. Note that the va-link component supports aria-label via the label prop.

References


Next Steps for the VFS Team

loripusey commented 3 months ago

Please add your planning poker estimate with Zenhub @brianseek

brianseek commented 3 months ago

@benbrasso-agile6 / @loripusey this is ready to validate in our branch. See PR for screenshots

benbrasso-agile6 commented 3 months ago

@brianseek did that PR link die?

loripusey commented 3 months ago

PR link doesn't work for me either

brianseek commented 3 months ago

@benbrasso-agile6 ah zenhub made the link weird https://github.com/department-of-veterans-affairs/vets-website/pull/30983

benbrasso-agile6 commented 3 months ago

LGTM

loripusey commented 3 months ago

@brianseek ready to close?

brianseek commented 3 months ago

yup