search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Direct Scheduled appointment and appointment request reasoncode.text - additionalAppointmentDetails rename to patientComments #89163

Closed JunTaoLuo closed 1 month ago

JunTaoLuo commented 1 month ago

Summary

We had a discussion in a related PR review and decided that the name patientComments is a more appropriate name for the new field that was added in https://github.com/department-of-veterans-affairs/va.gov-team/issues/86917. This issue tracks the renaming of this field. Note that this is a newly added field that hasn't been used anywhere yet so we can rename this without any downstream conflicts.

patientComments: should return whatever comments from reasonCode returns. i,e: 'test'.

Related spike: https://app.zenhub.com/workspaces/appointments-team-603fdef281af6500110a1691/issues/gh/department-of-veterans-affairs/va.gov-team/82597

AC:

JunTaoLuo commented 1 month ago

@vbahinwillit Do you mind running the validation for this ticket since your PR is dependent on this change?

simiadebowale commented 1 month ago

Validated in staging