department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

MVP Upstream Services - Define and implement integration best practices #89207

Open jennb33 opened 3 months ago

jennb33 commented 3 months ago

User Story

As the Managers and Developers of the Platform, We need to define and implement Integration Best Practices, So that the Services integration is done consistently going forward.

Issue Description

We need an MVP list of the upstream services that Vets API calls out to. There is some existing documentation and diagrams around this, but they're pretty stale and outdated. We should comb through the various sources of truth to determine an up to date list. This includes the fwdproxy, Vets API code, existing topology graphs, documentation, etc. This task could be a combined effort for Devops and Backend engineers.

Please refer to this document for VSP Downstream Map and this for External Integrations.

Please refer to this document for External Service Integrations information. We may be combining efforts with Platform Security, and they have listed this information as what they are collecting in a priority schedule.

Tasks

Success Metrics

There is an established best practices method for integration with external services that can be shared with other Platform teams.

Acceptance Criteria

Validation

Assignee to add steps to this section. List the actions that need to be taken to confirm this issue is complete. Include any necessary links or context. State the expected outcome.

jwoodman5 commented 2 days ago

Review current documentation to see if there are any gaps.