department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

526e Missing Information Message - content update #89576

Closed lisacapaccioli closed 2 weeks ago

lisacapaccioli commented 3 months ago

Users who are missing the following: SSN, DOB, EDIPI/Birls ID, Participant ID / File ID, must contact the 1-800-MyVA411 to get the missing information added to their MPI.

Currently a message exists in production (release July 2024) with some misleading information. Changes to the content are needed to more accurately support the Veteran:

Current Message Content

We’re missing your {formattedIdentifiers}. We need this information before you can {titleLowerCase(title)}. Call us at{' ’} ( ) to update your information. We’re here Monday through Friday from 8:00 a.m. to 9:00 p.m. ET. Tell the representative that you want to add this missing information to your file. We’re missing your {formattedIdentifiers}

Current image in production (wrong information is highlighted in pink):

Image

Notes

CONTACTS.HELP_DESK

Acceptance Criteria:

If the missing information is: EDIPI and/or BIRLS ID, then add the following content per these conditions:

Examples:

We're missing your Social Security Number. We need this information before you can file for disability compensation with VA Form 21-526EZ. Call us 800-698-2411 (TTY: 711) to update your information. We're here 24/7. Tell the representative that you want to add this missing information to your file.

We're missing your BIRLS ID. We need this information before you can file for disability compensation with VA Form 21-526EZ. Call us at 800-698-2411 (TTY: 711) to update your information. We're here 24/7. It's ok if you don't know your BIRLS ID. Tell the representative that you want to add this missing information to your file.

We're missing your BIRLS ID and EDIPI ID. We need this information before you can file for disability compensation with VA Form 21-526EZ. Call us at 800-698-2411 (TTY: 711) to update your information. We're here 24/7. It's ok if you don't know your BIRLS ID or EDIPI ID. Tell the representative that you want to add this missing information to your file.

### Downstream dependency
- [ ] https://github.com/department-of-veterans-affairs/va.gov-team/issues/89179
juliepedtke commented 3 months ago

Update from CAIA: for the pink highlight, we can replace the copy with...

We're here 24/7.

The phone number displayed should stay the same (eg we don't refer to it as "MyVA411")

CAIA asked a good question about defining what a BIRLS ID is, because this is likely an unfamiliar term to Veterans. We know the help desk reps are familiar with it, but I'd like to get more clarity on how they use it, how we might better describe it to the Veteran, etc. @lisacapaccioli to reach out with these questions for them. (See Slack thread.)

lisacapaccioli commented 2 months ago

Sent an email asking for more information.

juliepedtke commented 2 months ago

Info we learned from Jeremy Haas:

Based on this, I'd like to consider adding a conditional sentence: "It's ok if you don't know your BIRLS ID." before "Tell the representative that you want to add this missing info to your file." Let's ask how much of a technical lift this would be!

lisacapaccioli commented 2 months ago

@juliepedtke Let me know if the two AC's above match your expectations. Thanks

juliepedtke commented 2 months ago

Yes that looks right! Just to be extra clear, the formatting will be the same as the original message (no actual bold - that just indicates the new text). And we don't currently repeat the missing identifiers in a second paragraph, right? So they would only be mentioned once at the beginning and we'd remove the second "We're missing your {formattedIdentifiers}" on both messages.

lisacapaccioli commented 2 months ago

@juliepedtke Actually we do repeat the missing identifiers in the second paragraph. Thomas copied that straight out of production.

juliepedtke commented 2 months ago

Oh interesting, it's not shown in the screenshot. My sense is it's not necessary to repeat it again, so I'd suggest removing.

lisacapaccioli commented 2 months ago

Sorry @juliepedtke thought of one more thing. The EPIDS ID, should we assume that we will display the new content "It's ok if you don't know your ..." if the missing information is EDIPI ID or BIRLS ID? What if it's both?

juliepedtke commented 2 months ago

Good catch... so those are two different IDs that would show up listed separately? I have all the same questions about EPIDS (do we know what it is, will reps know what it is, is it ok that Veterans don't know what it is) but don't want to hold us up... so feels like a safe assumption to treat it the same as BIRLS!

If both BIRLS and EPID: "It's ok if you don't know your BIRLS ID or EPIDS ID."

If just BIRLS: "It's ok if you don't know your BIRLS ID."

If just EPIDS: "It's ok if you don't know your EPIDS ID."

lisacapaccioli commented 2 months ago

Yes, I do know that that EPIDS is familiar to the reps. I remember Jeremy mentioning that one. It was BIRLS that we didn't ask about. I think it will be safe to assume that Veterans don't (Thomas commented that his own father didn't).

lisacapaccioli commented 2 months ago

R&D is done, just need to implement the change.

SamStuckey commented 1 month ago

UPDATE: this is WIP, but i'm having delays with some environmental issues. Nothing project related, just stuff specific to my development environment. Working through them now

Slack thread

kylesoskin commented 1 month ago

In some situations this screen shows up differently than is pictured above, it also uses different/mismatched verbiage to wat is described in the the acceptance criteria (We're here 24/7 vs We’re here 24 hours a day, 7 days a week.) Screenshot 2024-09-19 at 9 37 09 AM (taken with mocked user Alfredo, user 100, on local machine)

I am wondering where that screenshot came from and if it is outdated before implementing this, or if the scope needs expanded to sync/evaluate ALL possible states of error here to make sure they align.

lisacapaccioli commented 1 month ago

@kylesoskin The screen shot (as mentioned right above it) is the current image and wrong text that is in production and needs to be changed. The acceptance criteria is correct in how it needs to change. Design doesn't need to create new images in Figma for content changes, but they do need a new image to put the in the Product handbook. We are waiting for this to be delivered to staging and tested to capture a new screen shot. If the acceptance criteria is not clear enough we can refine them better. If including the image is too confusing, we can remove it.

kylesoskin commented 1 month ago

@lisacapaccioli

The screen shot (as mentioned right above it) is the current image and wrong text that is in production

My comment is saying that this does not seem true, what is in prod code is what is in my screenshot, which does not align with what is in their screenshot. I am saying that there are multiple versions of this page, that show up differently depending on the state/attributes of the user, and that verbiage between them is different, and that this ticket does not account for multiple possible states of what shows up on this page.

if including the image is too confusing, we can remove it.

Including the image is not confusing. It is just 1 state of this page, the other states are not represented and say things that are different from this page. If the ticket is to ONLY update, this 1 state of this page, while leaving the other wrong still, that is fine. If we are fine with users being shown inconsistency across error messages, that is also fine, just want to clarify before implementing, since other have not, which is what allowed it to get in this state in the first place.

kylesoskin commented 1 month ago

Relevant code

Where we decide which content to show in this area https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/applications/disability-benefits/all-claims/Form526EZApp.jsx#L216-L238

What we show if missing birls id or edipi https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/applications/disability-benefits/all-claims/containers/Missing526Identifiers.jsx#L83-L94

What we show when there is a missing DOB, Service, or Edipi/Birls (shouldn't get triggered because first thing should take precedence??) https://github.com/department-of-veterans-affairs/vets-website/blob/main/src/applications/disability-benefits/all-claims/containers/MissingServices.jsx#L102

Need to verify how and when this gets triggered because the new component, that was made by Nathan, does not appear to be used for me locally.

lisacapaccioli commented 1 month ago

@kylesoskin OK. Thomas gave me the content that you are showing for missing BIRLS ID or EDIPI and Nathan gave me the screen shot. When Nathan is back we'll do another refinement for this and get some clarification on why we had a message that was different than what you are seeing. Thanks for the clarification. Moving this back to needs refinement.

kylesoskin commented 1 month ago

After further information, this discrepancy between how things are showing up locally vs in staging has to do with a variable that is not populating locally but does in staging.

form526RequiredIdentifierPresence is not present in the profile object locally, I think it might have something to do with mocked auth. I can try to figure that out, but might be easier just to instead make the change and get it into staging and check? Screenshot 2024-09-19 at 1 28 20 PM

kylesoskin commented 1 month ago

linked this issue to a flipper from a PR from @NB28VT .... form_526_required_identifiers_in_user_object, once toggled I can recreate locally and continue development. We should rip the old code, and this flipper out though, it took a while to understand what was going on here.

kylesoskin commented 1 month ago

Image EDIPI missing state

Image BIRLS missing state

Image Missing both EDIPI and BIRLS state

kylesoskin commented 1 month ago

Remaining work

nnicholas7 commented 1 month ago

A ticket has been created for VEO review. Ticket. Awaiting review and response.

kylesoskin commented 4 weeks ago

@nnicholas7 @lisacapaccioli

If we look at this functionality, and you can see this in the last picture, it will show ALL missing things, from the list of what it checks, not just birls and edipi, there are other things it needs too.

participantId: true, birlsId: true, ssn: true, birthDate: true, edipi: false,

are all checked, and all potentially able to show up in the verbiage.

For ssn and birthday it is probably fine that we dont tell them it is ok if they dont know it, they will know those.

But do we need to account for participant ID too? IE tell them it is ok if that is not known also?

lisacapaccioli commented 4 weeks ago

@kylesoskin - I updated the AC's to include Participant ID. So any combination of the three IDs would have the extra content "if you don't know...". Thanks

shannonkford commented 4 weeks ago

@kylesoskin Makes sense to me to include participant ID as noted above. Just here to note that the final 3 screenshots do not match the acceptance criteria copy - the "We're here 24/7" is misplaced and should come after the sentence containing the phone number.

kylesoskin commented 3 weeks ago

@shannonkford Ah, great catch 🤦 , thank you

kylesoskin commented 3 weeks ago

@lisacapaccioli @shannonkford was there any preference on EDIPI vs EDIPI ID? It looks we were using EDIPI in the top part telling them what is missing and using EDIPI ID in the its OK message. I imagine we want these to be consistent, just need to know which is correct.

EDIPI stands for Electronic Data Interchange Personal Identifier, so putting ID is redundant, but the user may have no idea what it stands for.

kylesoskin commented 3 weeks ago

New images/screenshots

Image Image Image

lisacapaccioli commented 3 weeks ago

@kylesoskin sorry, I didn't see your question about whether to include "ID" in EDIPI. I see you didn't and I think that is fine. R&D wrote the content, I just copied it. Thanks

kylesoskin commented 3 weeks ago

@nnicholas7 is this good to merge? I see the VEO ticket was approved/closed so I assume it is good to go just want to confirm before merging.

Also someone brought up if it should be okay instead of ok ? I said I just wrote what I was given but that I would pass along that concern.

lisacapaccioli commented 2 weeks ago

@kylesoskin @nnicholas7 If we are not sure about "ok" vs. "okay" we can check with Julie, I used the content she provided.

I need to let CC know that we fixed the content with the correct times and the release date. Just let me know what you think that date will be.

I will be mentioning these product guides: 526.Benefits.Delivery.at.Discharge.v3.3.product.guide_SRT_10032024.docx 526EZ.Disability.Benefits.Claims.Product.Guide.v4.3.SRT_10022024.docx

Thanks

nnicholas7 commented 2 weeks ago

Lisa will check with Julie about the 'ok' vs 'okay'. The product guide update has been avoided and is ready for production. Other information about this ticket is located here.

rubensun commented 2 weeks ago

Let's just use OK in capitals.

lisacapaccioli commented 2 weeks ago

Email to CC sent.