search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

Update steps on removing feature toggles to include an important order of removal #89615

Closed carlosfelix2 closed 1 month ago

carlosfelix2 commented 2 months ago

Description

Need to update the steps on removing feature toggles to include an important order of removal. Here is a suggested revision on the steps for the section titled "Removing old/unused feature toggles"

  1. Remove all references to your :feature_toggle_name in the app(s).
  2. Verify that the app(s) changes have been deployed to production before proceeding.
  3. Remove the respective lines from config/features.yml in the vets-api repository. This cannot be deployed before the app changes or your features will be turned off by default regardless of the flipper settings.
  4. Verify the config/features.yml changes have been deployed to production before proceeding.
  5. (Less obvious) - Delete feature from the respective databases

Relevant URLs

https://depo-platform-documentation.scrollhelp.site/developer-docs/feature-toggles-guide#Featuretogglesguide-Removingold/unusedfeaturetoggles

Which type of team are you on? (Platform team, VFS team, or Leadership)

MHV Cartography Team

taylojill commented 2 months ago

Hi @carlosfelix2 - thanks for your content suggestions. The Platform Content team will review your request and put it in our backlog to refine for next steps.

jknipes commented 1 month ago

Submitted SME recommendation request via Slack Platform Support channel

jknipes commented 1 month ago

Updated content approved by @ericboehs , discussion in this Slack thread. Page will be checked for launch blockers and deployed on 9/3. Ticket can be closed once successfully deployed.

jknipes commented 1 month ago

@carlosfelix2 the Page has been deployed with your updates. Thank you!