Production error when ICN is improperly formatted

Summary

Issue reported by Marcy Nadeau:

Can you check for a specific error in production?
The error would contain this text: Invalid Patient Integration Control Number My automated VAOS test has found an error and I want to know if this same error is happening in production.

Here is the endpoint: https://staging-api.va.gov/vaos/v2/appointments?_include=facilities,clinics&start=2024-06-30&end=2025-08-29&statuses[]=booked&statuses[]=arrived&statuses[]=fulfilled&statuses[]=cancelled

Here is the error:

"failures": [
            {
                "system": "VSP",
                "id": "0100550b-33a5-4a87-b984-4db11bcd55bc",
                "status": "500",
                "code": 6000,
                "message": "There were errors fetching appointments from VSP: Resource types: [appointments, requests]: Invalid Patient Integration Control Number (ICN): 1012667219.; Invalid Patient Integration Control Number (ICN): 1012667219."
            }
        ]
    }
}

There is a JIRA ticket for the staging incident: https://issues.mobilehealth.va.gov/browse/VAOSR-8347

Specs

From @cferris32 Looks like we're seeing that error as well, started about a week ago on the 23rd. According to the log error messages it seems like the issue is with a . getting appended to the ICN so it becomes invalid.

As a safety measure on our side I can work on a fix to scrub the ICN of misc characters like that and double check any related logic we might already have.

The silver lining is that there are only 99 errors of that nature in this timeframe though, which is relatively a very small amount. So I'm not sure what circumstances are causing the ICN to be modified that amount

Steps to Reproduce

Test User:

Go to: URL

Actual Result

Error message received when fetching appointments: "There were errors fetching appointments from VSP: Resource types: [appointments, requests]: Invalid Patient Integration Control Number (ICN): 1012667219.; Invalid Patient Integration Control Number (ICN): 1012667219."

Desired Result

Extra characters following ICN number are removed before retrieving appointments. No error message is returned.

Definition of Done

[ ] Desired result is achieved and/or document decisions made
[ ] Relevant documentation is updated

department-of-veterans-affairs / va.gov-team