department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 202 forks source link

CDP - Replace Mocked Payment History Data with API Response Data #89653

Closed OptionSelect closed 1 month ago

OptionSelect commented 2 months ago

Description

Local data has been standing in place of API response, to aid in implementing the design, that should be the real data we use.

Tasks

Acceptance criteria

OptionSelect commented 2 months ago

This ticket was created as a follow up to this one

Which merged this pr

mgleo commented 2 months ago

@OptionSelect Questions (based on Transaction code file)

What text will we display for:

Is there initial transaction where we can display when the overpayment was first acquired?

OptionSelect commented 2 months ago

@mgleo

Text Display Q: Currently we don't handle them! For this initial implementation I think we were just going with the two cases shown here. Next steps would be to incorporate a switch that works with your transaction code file linked above I believe. Provided I understand ya correctly!

image.png

Initial transaction Q: Yes, in the screenshot of the PaymentHistoryTable.jsx file we have a hardcoded row that will always display the corresponding initial overpayment info image.png

mgleo commented 2 months ago

Thanks @OptionSelect What will the user see if there is a transaction labeled Other, Reversal, Write Off? Will the transaction not show up at all? I'm wondering if we can add some text to these 3 labels? Maybe even adding "Other, Reversal, Write Off" to the corresponding label? Is that possible?

Also, I'm seeing 04Q and 08Q on your first screenshot (thank you for sharing it). Are the other codes for decrease and increase being accounted for? The Transaction Mapping file shows several more codes. What will a user see if they get a code other than 04Q and 08Q?

cc @josephrlee

OptionSelect commented 2 months ago
  1. Yep afaik we're returning null so nothing will show beyond the initial overpayment cell. We can certainly try, Ill mess with that while doing the dev here.
  2. This scenario is unfortunately the same as above, nothing if not having those codes I think lol. Its what it all comes down to displaying the text in the Description cell! Let us know what you want us to say for each code and we can do it! But it looked to me like some reported under the same so not sure.

@Dr-Pongo cc @amponce

mgleo commented 2 months ago

Thanks @OptionSelect -- It would be ideal to display all transactions, otherwise the total displayed won't add up.

For now can all codes within the categories display text with the same name? Other: "Other" Reversal: "Reversal" Write Off: "Write off"

OptionSelect commented 2 months ago

Let me finish hooking up the variables and get back to you on adding on!

OptionSelect commented 2 months ago

Worked with Megan on display text, replaced variables. PR is up.