department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

[Spike] Fixes discovery and planning #89739

Closed lisacapaccioli closed 2 weeks ago

lisacapaccioli commented 1 month ago

As a Product Manager, I need to understand the issues for the Veteran evidence document uploads that are preventing the documents from actually "uploading" in the VA systems, so that we can refine and prioritize the work on them.

For this to be successful

  1. Create a report identifying all the issues
  2. Identify the issue (using what was done in discovery)
  3. Identify the root cause (example - it it a backend problem that a Veteran has no control over or is it something that the Veteran has to change because we have rules for evidence uploads)
  4. If possible, identify the suggested solution (not all issues can be solved so easily, but some might, provide some ideas that the Team could discuss)
  5. If possible, identify the effort or additional work that is needed (does it need more discovery, is there a dependency, is there UI changes necessary, etc.)
  6. If any, identify risks (excluding the known risk which is that a Veteran may not get their benefits)
  7. Sharable - this will be shared in the review and to our partners

Suggestions for the report

Resources:

https://developer.va.gov/explore/api/benefits-intake/docs?version=current https://app.mural.co/t/departmentofveteransaffairs9999/m/departmentofveteransaffairs9999/1718308823134/02c2c9ea74f16b276692af8f31eb65202acc7928?sender=ua8d1f105fba69675aba15464 https://github.com/department-of-veterans-affairs/va.gov-team/issues/88577#issuecomment-2240489981

ajones446 commented 1 month ago

High-level suggestions:

  1. Refine backlog of existing tickets, several of these issues are already open and should be condensed/closed in coordination with other teams following them.
  2. Determine a strategy for monitoring ongoing error numbers as fixes are introduced.
  3. Look into adding .txt file validations (like ValidatePdf module) to enforce encoding and verify mime types.

Detailed notes reported in this spreadsheet

Scott's full report with more context here

ajones446 commented 2 weeks ago

Going forward, the upload process will use the Lighthouse Benefits Documents API instead of EVSS as part of the Lighthouse Document Upload Migration Epic. The Lighthouse API has additional requirements that need to be validated, which will be explored in the following spike for evidence uploads error responses on Lighthouse.

The root cause of many existing EVSS errors are likely to cause an error on Lighthouse as well, specifically the following issues:

These following tickets are related to EVSS upload failures and may be applicable to Lighthouse, listing here for reference: