department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Remove Standard/Daylight indicator from timezones in appointment lists #89802

Closed outerpress closed 1 week ago

outerpress commented 1 month ago

Description

What details are necessary for understanding the specific work or request tracked by this issue?

Based on content guidelines, we shouldn't include Daylight/Standard indicators in time zones.

We've removed most of these but Hawaiian time is still showing as HST

Screenshot from Judy Morrison's past appointments:

Screenshot 2024-08-01 at 7.35.56 AM.png

This ticket:


Development Checklist

Background: the toggle toggle is on (remove if not needed)

Design Assets

Developer Reference

Definition of Done


How to configure this issue (Delete this section before creating the ticket)

Bren22va commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @cferris32 @jenniemc @JunTaoLuo @ryanshaw @simiadebowale @vbahinwillit

JunTaoLuo commented 3 weeks ago

Edit: Updated timezones and abbreviations based on Simi's findings.

Here are some notes from investigating the timezone display logic.

First there are two parts to the display logic:

  1. The current logic only supports removing the S/D indicator for America/* timezones
  2. The abbreviations that will have the S/D removed are PST,MST,CST,EST,AKST as well as their daylight savings counterparts.

The list of timezones and locations that exhibit the bug described in this issue include:

Proposed next steps:

  1. Create sample appointments in all of these facilities and timezones for validation in staging.
  2. Update the first part of the logic to also include Pacific/* timezones
  3. Update second part of the logic to also include HST,SST,ChST,AST
simiadebowale commented 2 weeks ago

Hey @JunTaoLuo - I was able to confirm the following timezones returned by LH:

ldelacosta commented 1 week ago

@outerpress - this is ready to be validated in staging.

outerpress commented 1 week ago

Looks good! Thanks @JunTaoLuo - fyi @ldelacosta

Screenshot 2024-09-03 at 4.03.00 PM.png
ldelacosta commented 1 week ago

No issues to report. Closing out the ticket.