Midpoint Review - Accessibility Feedback - Unified Appointment Experience, Patient Check In, Add Upcoming Appointments

briandeconinck commented 3 months ago

Next Steps for the VFS team

[x] Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
[x] Comment on this ticket:
- If the Platform reviewer has any Thoughts/Questions that require responses.
- When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
- When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
[ ] Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
[ ] Close the ticket when all feedback has been addressed.

Thoughts/questions

Sorry for the late feedback!
All of this looks great. No concerns from me!

Feedback

Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).

[ ] Coding/Content note: There was some discussion in the meeting about the repeated use of "appointment" in the Manage Your Appointments section of the page. I'm not particularly bothered by it, but if you'd like to streamline it here are some considerations:
- Since the expected use case for the vast majority of users is that they'll be on their phone, it's a safe bet that mobile screen reader users will probably swipe through the heading, and thus get the appropriate context for the links that follow. But there might still be an edge case where someone is receiving text messages on a laptop and using that device for pre-check-in and check-in, and thus would be using a desktop screen reader. I think most screen reader users will probably navigate by heading on a page like this, so again, they'll get that context. But some screen reader users may just tab through links, especially newer screen reader users. Even those users will probably be able to get from context that the links are related to appointments, but reducing the cognitive load of figuring out where a link goes is always good.
- With that in mind, there are two approaches:
  - Content: Make sure the link text is phrased to provide sufficient context for where they're going, even if you missed that heading. What you have now satisfies that ("Review today's appointments"), but I don't think it's the only way to do it. Try to aim for complete phrases, like "Review your schedule for today" rather than "Today" or "Upcoming" etc.
  - Code: If there's not a clear content solution, the best bet here would be to add an aria-label, eg. <a href="..." aria-label="Today's appointments">Today</a>. But I have a strong preference for a content solution here --- the ARIA route should only be if you're really painted into a content corner.