department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

BE | Profile | Direct Deposit | 200 response missing control info #89955

Closed tpharrison closed 5 days ago

tpharrison commented 1 month ago

Background

Mobile team was investigating this 500 error. The Mobile::V0::Adapters::LighthouseDirectDeposit is throwing an error because account_control_info['can_update_direct_deposit'] is nil.

Reached out to the LH team to ask is a 200 response can be missing control information.

Tasks

Acceptance Criteria

tpharrison commented 1 month ago

@mtcA6 Who should we reach out to at BGS about this?

mtcA6 commented 1 month ago

@tpharrison John Dell and Jinmay Patel

tpharrison commented 1 month ago

Reached out to Jinmay on Aug14.

tpharrison commented 5 days ago

Followed up on this issue on Sept 6th.

The BIS and LH responses don't seem consistent. I've discussed with Kris Pethtel (mobile team) and we've decided to raise a 404 error if control information is missing from a 200 response from LH.

mtcA6 commented 5 days ago

@tpharrison do you need another ticket to implement that change or have you already taken care of that?

Also, I agree w/the approach for what it's worth. My only reservation is around the quantity of these errors. Roughly how many have we seen since launching? and can you tell if they are unique visits or happening for a select few?

tpharrison commented 5 days ago

@mtcA6 Mobile-related traffic has seen about 2 of these errors per day (different users). These errors haven't shown up in web-related traffic (but I'll check again).

I believe Kris is going to make the change which will apply to both mobile and web. If not, then I'll let you know and we can create a ticket.