HLR | Focus shift issue - Githubissues

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

282 stars 203 forks source link

HLR | Focus shift issue #90112

Closed eileen-coforma closed 1 month ago

eileen-coforma commented 2 months ago

What happened?

Describe what went wrong:

When page loads, it initially goes to focus, then it disappears and the page shifts, which can be jarring for users.

Add the steps to reproduce the bug:

Get to scheduling your informal conference
Hit back or make a selection
The page and the page before and after shift after a bit, like it's reloading, and the focus disappears.

https://github.com/user-attachments/assets/db5b704a-d3dd-42df-86c2-3d885dee887e

How severe is the problem?

[ ] Critical: User is block or significantly hindered from submitting the form, data is lost, or claim and evidence test coverage is missing. Fix ASAP.
[x] Moderate: User is not blocked, but the happy path is interrupted. Fix after critical bugs.
[ ] Minor: Cosmetic bugs and minor language inconsistencies. Defer to a later sprint.

What is the desired behavior?

_When a user does loads the page, the visual result is the page scrolls to where the focus is, focus is shown by yellow outline
When a user does X, the backend result is y.
When a user does X, the event logging result is y.

Definition of Done

[ ] Acceptance criteria reviewed and approved by product or design
[ ] Unit test (or other test coverage) added if possible
[ ] Logging and monitoring in place

dfong-adh commented 2 months ago

Pending merge once code review is done

dfong-adh commented 2 months ago

PR to be updated to address failing tests

Mottie commented 2 months ago

I've closed the pull request I had in code review - there have been too many issues piling on top of issues, so I'm going to break the work down into smaller chunks.

dfong-adh commented 2 months ago

PR pending review, then other PRs will be ready once merged

dfong-adh commented 2 months ago

Robin investigating failing end to end tests

dfong-adh commented 2 months ago

Test issues resolved, pending code review from other teams

eileen-coforma commented 1 month ago

Merged in. Encountered problem on the review and submit page where checking a checkbox will cause page to scroll to top. Robin to pick this back up.

eileen-coforma commented 1 month ago

PR in for the review and submit checkbox bug

eileen-coforma commented 1 month ago

This fix looks good 👍

eileen-coforma commented 1 month ago

Also fixed focus issue on review and submit page after clicking checkbox (for prototype)