Design Intent - Accessibility Feedback - Modernized Check-in, Appointments, Travel Claims for Past Appointments

[briandeconinck]

Next Steps for the VFS team

• [x] Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
• [x] Comment on this ticket:
  • If the Platform reviewer has any Thoughts/Questions that require responses.
  • When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
  • When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
• [ ] Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
• [x] Close the ticket when all feedback has been addressed.

Thoughts/questions

• Overall this looks good!

Feedback

Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).

• [x] Should: I see that you've already re-worked the mileage/other expenses question as "Are you claiming only mileage?" --- I think that works! Definitely easier to parse than the two-questions-in-one that were there before. I'd encourage you to move the first additional info ("How we calculate mileage") after the yes/no radio buttons rather than before, stacked with the other additional info. I don't think it's critical information to answer the question, and a screen reader user might get a little off track going from the question to a sidequest and then back to the yes/no question.
• [x] Coding note: I realize this is a Design Intent so this might not be super relevant yet, but when you get to the point of coding this, I would recommend wrapping the H1 and the date/time/clinic name/appointment type all in a legend associated with the fieldset containing the yes/no options. There's some extra CSS work required to make everything in the legend look the way you want it to look here, but that should ensure screen reader users tabbing to the yes/no questions get all of the context they need.
• [x] Should: In the appointment card, I don't think the aria-label is necessary in this context. Just the visible link text should be sufficient.
• [x] Should: In the appointment card, the two links to file a travel reimbursement claim (at the top and at the bottom) should have the same link text. It's not a WCAG violation for links going to the same place to have different text, but it is a possible point of confusion, eg. a Veteran not being sure which one will take them to the place they want to go. It's probably not likely to be a problem, but it's an easy spot to reduce some friction.

Governance team actions

• [x] Format feedback as individual tasks (check boxes)
• [x] Assign this ticket to the VFS team member that opened the Slack request
• [x] Add the VFS team product label
• [x] Add the VFS team the feature label (if applicable)
• [x] Add the touchpoint labels
• [x] Add the practice area labels
• [x] Add the Collaboration Cycle initiative milestone

[benbrasso-agile6]

@micahtaylor 1 and 2 are yours :)

[benbrasso-agile6]

Should: In the appointment card, I don't think the aria-label is necessary in this context. Just the visible link text should be sufficient.

Done

[benbrasso-agile6]

Should: In the appointment card, the two links to file a travel reimbursement claim (at the top and at the bottom) should have the same link text. It's not a WCAG violation for links going to the same place to have different text, but it is a possible point of confusion, eg. a Veteran not being sure which one will take them to the place they want to go. It's probably not likely to be a problem, but it's an easy spot to reduce some friction.

Done. Micah has "file a travel reimbursement claim" on the intro page, so we'll go with that.

[micahtaylor]

Done! I moved the "Are you claiming only mileage?" message and add a coding note to the Figma file for engineering