department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Midpoint Review - Design Feedback - Health, Supply Reordering Tool, Reordering Form #90561

Open allison0034 opened 1 month ago

allison0034 commented 1 month ago

Next Steps for the VFS team

Thoughts/questions

Feedback

Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).

Governance team actions

Jenny-yw commented 3 weeks ago

@allison0034 I have incorporated all the feedback in the same Figma file (also in the screenshots). Erin suggested that the "unavailable for reorder" section could be collapsed or otherwise shortened, which is similar to your "consider" feedback. Both makes sense. Question about the checkbox tile: Since I'm not using label header, can I bold the label of the checkbox to emphasize on the supply name?

Screenshot 2024-08-15 at 5 32 27 PM

allison0034 commented 3 weeks ago

@Jenny-yw is there any reason you are not using a label header? As long as there are no accessibility issues, bolding should be fine.

Jenny-yw commented 3 weeks ago

Got it, thank you! The label header in the DS is on top of the checkbox. I don't think a header would be useful since each checkbox tile already has all the necessary information for the supply (name and details).