search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

[Feature] VCR Cassette Cleanup and Pair Down #90689

Open ldelacosta opened 1 month ago

ldelacosta commented 1 month ago

There are a number of redundancies in our existing set of vcr cassettes we use for our vets-api test suite. With the logic of each api layer changing as part of our code consolidation initiative, we would benefit from a clean slate of test files to verify our upstream calls. We will want to record new http calls to our various endpoints to form a new baseline, then use mocks to fill in the gaps.

This work will likely be easiest to do once most changes to the services have taken place, but there may be edge cases that can be taken care of ahead of time. This ticket will capture that ongoing work and process.

AC: [ ] - record fresh vcr cassettes for the http calls to all of the vets-api appointments endpoints [ ] - use mocks and unit tests to fill in the remaining gaps [ ] - delete all the old cassettes

ldelacosta commented 1 month ago

@cferris32 @simiadebowale - please add the tickets under this epic.

JunTaoLuo commented 1 day ago

@cferris32 do we want to close this since we've done all we want for the time being? Or do you want to keep this open in anticipation of another round of work?