department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 199 forks source link

Accessibility tab issue on 526 pages #90759

Closed pacerwow closed 3 weeks ago

pacerwow commented 1 month ago

Issue Description

As a Veteran I want to navigate through the 526 form without a mouse so that I can submit an application even if I am not able to use a computer mouse.

When tabbing through the 526 form, we noticed that the tab button skips some of the radio buttons on a couple of pages. Noticed this for adaptive-benefits additional-disability-benefits

There may be more, will need to go back and look more thoroughly.


Tasks

Break this out (Jared to do) - these are not in scope

Acceptance Criteria


How to configure this issue

bacitracin commented 3 weeks ago

Hey there! Here's my repro results: I tested these 2 pages on staging with Chrome and Safari and could not recreate the bug of skipping radio buttons. I went over it with Tyler Spangler to make sure I wasn’t missing any hidden bits of the form.

Here is the expected behavior of the radio group, which I confirmed:

Both pages’ radio button groups are using the Yes-no widget from the VA forms library, so I’m pretty confident that it should be good. Here’s some additional documentation on expected behavior of the radio group pattern - https://www.w3.org/WAI/ARIA/apg/patterns/radio/.

If you have more repro directions, please let me know and I'll test it again. Otherwise if the behavior seems as described we can close this issue.

pacerwow commented 3 weeks ago

Thanks Tracy! Appreciate the thorough notes. I think the language I should have used was "move focus", not select. Would you mind taking 10 minutes to do a quick test using Edge to just make sure it's not reproducible there? If it's not, we can close the story.

Do you feel that a test case here is a good idea? If it's not, we can close the story.

bacitracin commented 3 weeks ago

@pacerwow Will do! I'll throw in Firefox too so we're covered on the browsers we support. I don't think a test case is necessary at the moment. If I don't find anything 🤞 , I'll close this issue.

bacitracin commented 3 weeks ago

Checked across 4 browsers and was not able to reproduce the bug. Closing this issue for now.

pacerwow commented 3 weeks ago

Sounds great, thanks!-JaredOn Aug 30, 2024, at 10:13 AM, Tracy Tran @.***> wrote: Checked across 4 browsers and was not able to reproduce the bug. Closing this issue for now.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>