department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: `How to check in` link opens in a new tab without notice #90774

Closed shiragoodman closed 2 weeks ago

shiragoodman commented 3 weeks ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: Pre-Check-in Feature: Medication Review

Findings details

VA.gov Experience Standard - issue: User experiences an unexpected interaction with a component or pattern. VA.gov Experience Standard - category: Usability Launch-blocking: No Design System review: No Collab Cycle Reviewer: @erinrwhite (IA), @briandeconinck (Accessibility)

Description

On the /complete/ and /appointment-details/ views, the "Find out how to check in" link unexpectedly opens in a new tab.

Recommended action

Our guidance for link behavior says to only open in a new tab if user data/progress could be lost. The link should either not open in a new tab (since the form flow is complete) or, if there is a reason a user might lose their progress if they navigate to this link, the link text should include "(opens in a new tab)" in its link text.

References


Next Steps for the VFS Team

benbrasso-agile6 commented 3 weeks ago

@wullaski change the link text to:

Find out how to check in (opens in new tab)

loripusey commented 3 weeks ago

Update content for both of these /complete/ and /appointment-details/

brianseek commented 2 weeks ago

@benbrasso-agile6 / @cgednalske / @zach-park this is merged and ready to validate. See screenshots in PR https://github.com/department-of-veterans-affairs/vets-website/pull/31603

benbrasso-agile6 commented 2 weeks ago

LGTM

brianseek commented 2 weeks ago

thanks @benbrasso-agile6! closing