Full Accessibility & 508 Office Audit Benefits Delivery at Discharge

luke-gcio commented 4 years ago

Steps to complete the Full Accessibility & 508 Audit:

[x] Product Manager: create issue and fill in feature name in the title and other bolded information appropriately
[ ] Practice area reviewers create sub-issues attached to this one with feedback for your team on feature name
[ ] Requesting team completes attached feedback tickets based on definition of done included in each practice area feedback ticket (may differ for each practice area, please refer to attached tickets for further instruction)
[ ] All requesting team attendees complete brief VSP Collaboration Cycle Feedback survey

Artifacts - please provide the following artifacts when you request a full review

Access information for the tool or feature in staging do not put staging credentials in your va.gov-team ticket; store or reference them in a .md file in the va.gov-team-sensitive repository

Accessibility Checks Completed — Self Check Stories:

8890 526 "Original Claims" and "All Claims"
9799 526 BDD

Test Cases

BDD flow:

Open the following URL in a new tab to reset the wizard that is shown on the introduction page: https://staging.va.gov/disability/file-disability-claim-form-21-526ez/introduction
Wizard: For separated from military question, choose "No"
Wizard: For anticipated date of release question, set date to May 1 2021 (less than 90 days from today)
Wizard: Use "File a Benefits Delivery at Discharge claim" button
Intro page: Sign in to user 228, or if already signed in use green button to start the form
Intent to file message: Use "continue" button
Step 1 of 5: Veteran details. Use "continue" button
- This would be a good place to use the Open save-in-progress menu popup link and paste in the BDD prefill data; if you don't know what this is, please message me and I can walk you through it
Step 1 of 5: Military service history.
- An existing history card should be collapsed with an "Edit" button
- A new card with Aug 1 2021 data should be prefilled in the "Service end dates" of a "New service period" card.
- Choose a "Branch of service" & enter a "Service start date" and use "Save" button, if not already prefilled
- "Continue" to next page
Step 1 of 5: Place of anticipated separation. Start typing and then choose an option in the dropdown, e.g. "Fort Dix", if not already prefilled
Now, everything is the same as form 526 until you reach this URL: https://staging.va.gov/disability/file-disability-claim-form-21-526ez/supporting-evidence/service-treatment-records
- This is the page where BDD users will need to upload their service treatment records.
The remainder of the flow is the exact same as other 526 claim types.

Additional Notes

As part of this review, VSP will send your product to VA's 508 office for approval (as applicable)

jenstrickland commented 4 years ago

@luke-gcio - Has the team completed the accessibility test cases documentation? I recommend using the checklist method to certify that the team completed the required accessibility testing. Please let me know if I may be of help to get this audit ready to go.

luke-gcio commented 4 years ago

Spoke to VSP - with the understanding that BDD is part of Disability Claims, they are ok with combining this when we get to BDD.

jenstrickland commented 4 years ago

👍 Is this ticket a request for the full accessibility audit now?

luke-gcio commented 4 years ago

We have combined 526 and BDD so we need to do a full audit for both at the same time (they are tied at the hip). We are ready to begin! I will go make sure the test accounts for staging are correct.

jenstrickland commented 4 years ago

It's okay to do this as a two-in-one. Thanks!

jenstrickland commented 3 years ago

@luke-gcio @Mottie

Would y'all please add the URLs to access and the Users to test to the details above? Also, it would be helpful to document the test cases to go through to test BDD.

Mottie commented 3 years ago

BDD flow:

Open the following URL in a new tab to reset the wizard that is shown on the introduction page: https://staging.va.gov/disability/file-disability-claim-form-21-526ez/introduction
Wizard: For are you currently on active duty, choose "Yes"
Wizard: For anticipated date of release question, set date to May 1 2021 (between 90 and 180 days from today)
Wizard: Use "File a Benefits Delivery at Discharge claim" button
Intro page: Sign in to user 228, or if already signed in use green button to start the form
Intent to file message: Use "continue" button
Step 1 of 5: Veteran details. Use "continue" button
- This would be a good place to use the Open save-in-progress menu popup link and paste in the BDD prefill data; if you don't know what this is, please message me and I can walk you through it
Step 1 of 5: Military service history.
- An existing history card should be collapsed with an "Edit" button
- A new card with May 1 2021 data should be prefilled in the "Service end dates" of a "New service period" card.
- Choose a "Branch of service" & enter a "Service start date" and use "Save" button, if not already prefilled
- "Continue" to next page
Step 1 of 5: Place of anticipated separation. Start typing and then choose an option in the dropdown, e.g. "Fort Dix", if not already prefilled
Now, everything is the same as form 526 until you reach this URL: https://staging.va.gov/disability/file-disability-claim-form-21-526ez/supporting-evidence/service-treatment-records
- This is the page where BDD users will need to upload their service treatment records.
The remainder of the flow is the exact same as other 526 claim types.

joshkimux commented 3 years ago

Not sure if a ticket has already been written up for the content here. Tagging @peggygannon for awareness!

peggygannon commented 3 years ago

Hi, @joshkimux Thank you... This content above is outdated. I've added below a link to the content outline we had recommended to the team for the 526/BDD wizard work and implementation. Please let me know if you have any questions.

https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/public-websites/how-to-apply-wizards/content-outlines/disability-form.md

cc @luke-gcio @johnhashva

joshkimux commented 3 years ago

Not an accessibility issue, but more of a usability one @Mottie @kevinstachura On the review page, if the user selects "no," they will lose all of their uploaded documents and will have to re-upload all of them if they re-select "yes"

https://user-images.githubusercontent.com/14154792/107548271-48ba7880-6b83-11eb-9601-57f5d4b529f1.mp4

joshkimux commented 3 years ago

Another usability issue here. Empty states do not have unique messaging: No-empty-state-disabilities

joshkimux commented 3 years ago

@1Copenut @luke-gcio I've tentatively completed this full a11y audit 🎉 Special thanks to @Mottie and @kevinstachura for answering all my questions and carrying the effort 🙇

I've noted this as tentative as additional issues may emerge while working on these tickets. Furthermore, I couldn't provide clear recommendations on some of the tickets as I think they deserve more conversation and thought. @1Copenut would love your review on these to see if they have appropriate severity levels and recommended solutions 🙏

Mottie commented 3 years ago

Hmm, that summary page shouldn't ever be blank. It'll contain any selected rated disability and all new disabilities. This may happen if you reload the page? If not, please let me know which user and if you made selections/added new disabilities. And if this happened after continuing a form, or you found it while stepping through the form in a single sitting. Thanks!

Mottie commented 3 years ago

That file upload problem you found... ouch... yeah that definitely needs to be fixed. I'll open a ticket.

Update: https://github.com/department-of-veterans-affairs/va.gov-team/issues/19806

joshkimux commented 3 years ago

@Mottie I'll check it again tomorrow! Fingers crossed it was just the browser being weird.

department-of-veterans-affairs / va.gov-team