department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

[FE] - Add past appointments features to details page #90975

Open brianseek opened 3 weeks ago

brianseek commented 3 weeks ago

Description

Create or use existing feature flag for this work. When the feature is on and its an in-person appointment, call the claims endpoint. Based on the result determine if we should add the action link and/or the Travel reimbursement content block. The action link only shows if there is no claim. When there is no claim the content block should show a count down of how many days are left to file. If there is a claim the content block should link to it.

Sequence Diagram

question: What do we do if the api call fails?

Wireframes

Tasks

Acceptance Criteria

Code Review Steps

loripusey commented 3 weeks ago

@benbrasso-agile6 @cgednalske are these the correct current wireframes? Is this ready for FE to work on? cc: @brianseek @wullaski

benbrasso-agile6 commented 3 weeks ago

Yes, correct wireframes.

It's ready, but we will be doing a research study for these. E.g., actions on appt detail pages.

Tough to say whether to complete these or wait for the results of that study. It will be unmoderated study, so it will be quicker.

loripusey commented 3 weeks ago

Perhaps it will give FE time to "get acquainted" with the Appointments code base; just want to make sure FE knows that there may be changes cc: @brianseek @wullaski

benbrasso-agile6 commented 3 weeks ago

I won't be at stand up today, maybe see what Christina and FE think is the best approach.

loripusey commented 3 weeks ago

there is no stand up today (planning day); it's up to @brianseek and @wullaski

benbrasso-agile6 commented 3 weeks ago

I see a comment from brian about api Call fails. We could create a ticket for UX to create that wireframe. Should be a small pointer that can be completed in this upcoming sprint.

benbrasso-agile6 commented 3 weeks ago

Yes; def think there will be small-ish design changes as a result of what we're going to test in research.

brianseek commented 3 weeks ago

I think we can do the work and update as we need to. We are doing the same thing with the mock api side of the work too. So we are expecting to create follow on work before being ready to flip the flag.

wullaski commented 1 week ago

I started a draft PR where the claim endpoint is called on the front-end. There's a new plan to move that call to the back-end and get the data we need along with the appointment data for past appointments. More info in this thread