search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Cleanup merge_clinic logic in appointments controller and service #91164

Open cferris32 opened 3 weeks ago

cferris32 commented 3 weeks ago

Through some recent talks with web we realized that we can pull the station and ien fields needed for the avs flow from fields straight off the appointment response body rather than needing to dig into the indentifier field like the extract_station_and_ien method does, so this work will be to clean up that method and ensure it's no longer needed.

AC: [ ] - cleanup of extract_station_and_ien method [ ] - ensure avs flow still functions correctly [ ] - test updates

JunTaoLuo commented 1 week ago

After discussing with @simiadebowale @cferris32 we decided to not update the current logic for extracting station and ien fields since the /vaos/v1/patients/#{user.icn}/appointments API do not explicitly return this directly. Instead of digging through the /vaos/v1/locations/#{station_id}/clinics API for this information via stationId and id we'll stay with the current logic for extracting staion and ien fields from identifiers from the /vaos/v1/patients/#{user.icn}/appointments API.

However, in this process we noticed there is some cleanup we can do in the appointments_controller and appointments_service for logic that merge clinic information with the appointment so we're repurposing this issue to track that work instead.