Limit phone number to 11 digits

steele-lm commented 3 months ago

Issue Description

_#91155 uncovered that the 686/674 application attempts to insert a value into the PHONE_NBR column of the VNP_PTCPNTPHONE table, but the value's length exceeds the maximum allowed for that column. This error is coming the 3rd party API as we're sending it 12 characters instead of the maximum of 11.

An example of the error that is occurring is in this link in the payload key "nested_error". This is causing the expected display of a phone numbers (907-707-9107) to trigger an error.

This ticket should not be worked on until https://github.com/department-of-veterans-affairs/va.gov-team/issues/91155 is resolved.

Several open questions remain about this change. See this thread.

Why are we now seeing the error in #91155? What changed?
RBPS may be relying on dashes, so we need to confirm the change with them first.
Could this error be related to adding international phone numbers?
Do we need to work with RBPS to support accepting international numbers that exceed 11 digits?

Tasks

[ ] Remove dashes in phone numbers
[ ] .strip the phone number

Acceptance Criteria

[ ] 686/674 application sends a maximum of 11 digit phone numbers to BGS

mjknight50 commented 3 months ago

Moving this over to @tfink419 as it relates to the https://github.com/department-of-veterans-affairs/va.gov-team/issues/91155

sanjabaj2 commented 1 month ago

The dependent ticket is closed. Should be able to unblock this. It would reduce number of cases that go via backup path.

steele-lm commented 1 month ago

@sanjabaj2 I think we had a lot of unanswered questions around why we're now seeing this issue and if we need to account for international numbers, which can exceed 11 digits. I'll add the questions to this ticket.

department-of-veterans-affairs / va.gov-team