department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Staging Review finding: Update your multiple responses pattern to match more closely to the new pattern #91343

Open shiragoodman opened 3 months ago

shiragoodman commented 3 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Disability Benefits Experience Team 1 Product: 21-526EZ Feature: Toxic Exposure Page

Findings details

VA.gov Experience Standard - issue: User encounters design components or patterns that are out of date. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @allison0034 (Design)

Description

I listened to the Midpoint Review recording and know that you were deviating slightly from our old multiple responses pattern by using check boxes and a more flat IA. We have since updated the multiple responses pattern and have a new preferred UI and pattern.

Recommended action

If you can, try to align your UI or pattern closer to the new one. Look at things like the card style and edit link and delete buttons.

References


Next Steps for the VFS Team

mayacarrolluxa6 commented 3 months ago

Taking a look at this now.

mayacarrolluxa6 commented 3 months ago

@pacerwow I’ve created a Figma file called ‘Design Debt,’ which you can find here: [(https://www.figma.com/design/p5WMWutzPPhJvOkJmPtIsJ/Design-Debt?node-id=0-1&t=PQCok80qTL4RGqCl-1.)]

In the file, you’ll see the screenshots I collected from staging that highlight all instances where the outdated list loop component is being used.

Updating the designs with the new Multiple Responses component will require significant effort from both design and front-end engineering.

Since this isn’t a launch-blocking issue, I recommend adding it to the backlog under ‘design debt’ and scheduling it for a future sprint when it won’t interfere with higher priority tasks.