department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Incorrect use of commas in "prepare for your appointment" list #91567

Closed shiragoodman closed 1 week ago

shiragoodman commented 2 weeks ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Appointments FE Team Product: Appointments Feature: Medication Review

Findings details

VA.gov Experience Standard - issue: User encounters content that does not align with VA.gov voice and tone content principles. VA.gov Experience Standard - category: Credibility Launch-blocking: No Design System review: No Collab Cycle Reviewer: @kkitagawa-bosch (content)

Description

In the video appointment details, under the header "prepare for your appointment", the text reads "bring your insurance cards and a list of your medications and other information to share with your provider." Since this list has three items, it should be comma-separated and include the oxford comma.

Recommended action

Change the list to read "bring your insurance cards, a list of your medications, and other information to share with your provider."

References


Next Steps for the VFS Team

outerpress commented 2 weeks ago

FYI @laurwill this tweaks the previous tweak of the medication review language by adding commas. FYI @loripusey @benbrasso-agile6 for the same sentence in the CIE medication review section.

benbrasso-agile6 commented 2 weeks ago

Thanks. Lori, either Zack or I will prep this change in Figma tomorrow. Not that it's urgent, but just to get it moving.

laurwill commented 2 weeks ago

Hey @benbrasso-agile6 @KKitagawa-Bosch , the intended meaning of the sentence was 2 items:

But clearly that was not clear! What if instead of a 3-item comma-separated list, we do: "Bring your insurance cards. And bring a list of your medications and other information to share with your provider."

KKitagawa-Bosch commented 2 weeks ago

Makes sense to me! @benbrasso-agile6 I would go with that. You can also replace "and" in the second sentence with "Also" if you prefer; whichever sounds best to your ear! (They're both technically correct)

outerpress commented 2 weeks ago

Thanks @KKitagawa-Bosch ! @laurwill any strong preference for "Also" vs. "And" ?

benbrasso-agile6 commented 2 weeks ago

And "sounds" nice to me; take that with a grain of salt

benbrasso-agile6 commented 2 weeks ago

@loripusey paragraph/content changes for pre-check-in FE under the Prepare for your appointment heading need a new ticket:

Complete page - https://www.figma.com/design/mVg6S9xgiQpWbAOAvptQOZ/Pre-check-in-%7C-PCI?node-id=285-17139&t=DbMmFHqAEf70oinX-4

Appt detail page - https://www.figma.com/design/mVg6S9xgiQpWbAOAvptQOZ/Pre-check-in-%7C-PCI?node-id=285-14615&t=DbMmFHqAEf70oinX-4

outerpress commented 2 weeks ago

Confirmed with @laurwill that we'll go with "And" - @ldelacosta I'll get the designs and dev ticket updated this afternoon. Thanks all!

loripusey commented 1 week ago

@benbrasso-agile6 do you need to update the CIE wireframes or are they ready for FE?

benbrasso-agile6 commented 1 week ago

Yes, see above comment with links

loripusey commented 1 week ago

@benbrasso-agile6 no, based on this comment, is there additional work on our wireframes that need to be done?

Confirmed with @laurwill that we'll go with "And" - @ldelacosta I'll get the designs and dev ticket updated this afternoon. Thanks all!

benbrasso-agile6 commented 1 week ago

The links I've provided have those updates. Unless you see something missing?

loripusey commented 1 week ago

Nope, just checking before turning it over to FE.

outerpress commented 1 week ago

@ldelacosta #91709 completed this work, so closing this one.