department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Inaccurate heading hierarchy on review page #91795

Closed shiragoodman closed 1 week ago

shiragoodman commented 2 weeks ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: eCheck-in Feature: Mileage-only Travel Claim Submissions for VA Facilities that use Oracle Health EHR Software

Findings details

VA.gov Experience Standard - issue: User encounters content that does not meet best practices. VA.gov Experience Standard - category: Comprehension Launch-blocking: No Design System review: No Collab Cycle Reviewer: @erinrwhite (IA), @briandeconinck (Accessibility)

Description

The Beneficiary travel agreement heading on the review page is an h3, while other headings on the page are h2's. As an h3 it appears to be nested under the h2 Starting address, though conceptually they should be grouped separately.

Link, screenshot or steps to recreate ![heading-hierarchy-2](https://github.com/user-attachments/assets/82db3c4a-3648-40ac-9ab3-c2aab01140ee) ![heading-hierarchy-1](https://github.com/user-attachments/assets/3b7b30e1-cd8c-409a-b15a-bd2939d05e56)

Recommended action

Adjust Beneficiary travel agreement to use an h2 heading.

References


Next Steps for the VFS Team

loripusey commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @brianseek @wullaski

brianseek commented 1 week ago

@benbrasso-agile6 @zach-park @cgednalske this is merged and ready to be validated locally or by looking at the screenshots on the PR: https://github.com/department-of-veterans-affairs/vets-website/pull/31773

benbrasso-agile6 commented 1 week ago

LGTM. @zach-park can you get this one updated in Figma too? This one can be updated in the prod Figma file as well. Check-in files.

zach-park commented 1 week ago

LGTM. @zach-park can you get this one updated in Figma too? This one can be updated in the prod Figma file as well. Check-in files.

Annotation (e.g., H2 with H3 styling) is added on both Check-in and Production Figma files.

brianseek commented 1 week ago

Thanks! closing